1853896 - Hide network status in DOM fullscreen (was: Status line visible on top of fullscreen videos)

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[andysem]

Attachment: Screenshot_20230919_141631.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/117.0

Steps to reproduce:

1. Open a Youtube video.
2. Play it and switch to fullscreen mode (press F or an icon in the UI).

Actual results:

The video opens fullscreen, but the status bar at the bottom of the screen (saying that it's performing a TLS handshake) stays above the video and visible. In my case, this status bar stays visible for a very long time (minutes?) and may even last to the end of the video. This is distracting.

This doesn't always happen and obviously depends on whether the status bar disappears naturally (e.g. when the relevant network activity finishes quick enough). I think, it may even not reproduce reliably (meaning that sometimes, even when the status bar is visible in non-fullscreen mode, switching to fullscreen will hide the status bar), but I'm not sure whether this happens because the status bar disappears naturally or because the fullscreen video covers it.

Expected results:

Fullscreen video should hide the status bar.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Audio/Video: Playback' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[andysem]

Attachment: about:support

I'm on Kubuntu 22.04, Nvidia driver 535.43.09, but I have seen this behavior with other driver versions as well.

Comment 3

[Jim Mathies [:jimm]]

Can you interact with the tooltip? For example, if you move your mouse over it, does it flip to the other side of the window? Trying to determine if this is a rendering anomaly or a browser front-end bug.

Comment 4

[Jim Mathies [:jimm]]

Possible dupe filed recently - Bug 1850544 - Link stays on the bottom corners when opening a youtube video

Comment 5

[andysem]

(In reply to Jim Mathies [:jimm] from comment #3)

Can you interact with the tooltip? For example, if you move your mouse over it, does it flip to the other side of the window? Trying to determine if this is a rendering anomaly or a browser front-end bug.

Yes, hovering over the status bar moves it to the other corner of the screen.

I think, it's always behaved this way, i.e. the status bar was always shown on top of fullscreen videos. But normally it would disappear quickly enough so it didn't bother. But in the past years it became progressively worse, because some of the network requests take more time or simply hang until timeout (e.g. when a certain website is not accessible, and some content on the page is pulled from it), which means the status bar is hanging visible for much longer periods of time over the video.

Comment 6

[Dana Lucaci, Desktop QA]

I tried to reproduce this issue on Firefox 117.0 (20230824132758) using Ubuntu 22 and Win 10, but with no success. Are there any additional steps (settings) or something that I'm missing?
Thank you!

Comment 7

[andysem]

No, no special configuration needed.

But, as I noted earlier, you probably need network requests to take long (possibly, until timeout) for this problem to become noticeable. So you may want to set up a firewall or bandwidth limiter or something in order to reproduce. (Again, I didn't; this just happens without any effort on my end.)

Comment 8

[andysem]

And also, I'll note again that this is not 100% reproducible. Which is not surprising, given that it is presumably caused by network activity.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit BugBot documentation.

Comment 10

[Jim Mathies [:jimm]]

Attachment: Amazon Prime TV

This is reproducible on MacOS for live broadcasts on Amazon Prime. If this is somehow audio/video related, happy to help. But my guess is this is something in front-end handling.

Comment 11

[Ardelean Oana, Desktop QA [:oardelean]]

We were able to reproduce bug 1853896 and bug 1850544 respectively but unfortunately we could not narrow down a regression range yet due to the fact that both bugs are intermittent. Tested and reproduced on Windows 10, macOS 12 and macOS 14 on Youtube, but not on Amazon Prime. We could reproduce up until a Nightly 60.0a1 build(2018-02-02), which indicates at least that this is not a recent regression.

Steps to reproduce:

1. Launch Firefox.
2. Open a youtube video in a new tab.
3. Quickly enter fullscreen(F) or via fullscreen icon.

Comment 12

[Dão Gottwald [:dao]]

Attachment: Bug 1853896 - Hide non-overlink statuses in DOM fullscreen.

Depends on D193919

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb20fcc066bf
Hide non-overlink statuses in DOM fullscreen. r=Gijs

Comment 14

[Dão Gottwald [:dao]]

Attachment: Bug 1853896 - Hide non-overlink statuses in DOM fullscreen (patch for uplift). r=gijs

Comment 15

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/fb20fcc066bf

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:dao, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox121 to wontfix.

For more information, please visit BugBot documentation.

Comment 17

[Dão Gottwald [:dao]]

Comment on attachment 9365220 [details]
Bug 1853896 - Hide non-overlink statuses in DOM fullscreen (patch for uplift). r=gijs

Beta/Release Uplift Approval Request

• User impact if declined: subpar user experience e.g. for watching video (I'm told American Football streaming season in particular makes this a current priorty, even to the point where we should consider it for the next dot release)
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: I found it tricky to get network statuses stick around long enough that they would still show when I entered DOM fullscreen mode, but QA managed to reproduce this in comment 11.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): very limited CSS-only patch
• String changes made/needed:
• Is Android affected?: No

Comment 18

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

Comment on attachment 9365220 [details]
Bug 1853896 - Hide non-overlink statuses in DOM fullscreen (patch for uplift). r=gijs

Approved for 121.0b4.

Comment 19

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/ef4226864e76

Comment 20

[Adrian Florinescu [:aflorinescu]]

Although we have caught the network status getting stuck in the past(comment 11) and not transfering to the address status, we didn't manage to do so now, in order to be able to verify this patch. Therefore, marking this fix as qe-, since we lack a reliable scenario to be able to verify it.

Comment 21

[Dianna Smith [:diannaS] - on Leave, back on August 9th]

Comment on attachment 9365220 [details]
Bug 1853896 - Hide non-overlink statuses in DOM fullscreen (patch for uplift). r=gijs

Approved for 120.0.1 dot release

Comment 22

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/b6ca25ae69ab