1850993 - The link URL status bar often gets stuck on YouTube (full screen mode)

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[Markus Stange [:mstange]]

When I watch YouTube videos in full screen mode, I often notice that the link status bar with a URL is shown in the bottom left corner, overlapping the video. It's annoyingly persistent; moving the mouse around over the video in full screen mode doesn't make it go away.

I've finally found out how this happens: It's because, after I click the video on the home page, I don't hover any other link before I enter full screen mode. And clicking the video link makes the link disappear without a navigation and in such a way that we don't notice that the mouse has left the link.

Steps to reproduce:

1. Go to https://www.youtube.com/
2. Optionally: Visit a random video, change the video mode to "Theater mode" (button next to the fullscreen button), and go back to the home page.
3. On the home page, move your mouse over a random video (link status bar appears) and click it.
4. On the video page, don't move your mouse over any other links.
5. Optionally: Double-click the video that's now playing to make it fullscreen.

Expected results:
After clicking the video on the home page, the link URL status bar should disappear.

Actual results:
The status bar remains visible. It is stuck until you hover another link, for example a suggested video or a user name in a comment. Moving your mouse over the video controls does not cause the status bar to hide.
It's easier to get into this state with theater mode because the right column of recommended videos is less likely to be under your mouse immediately after navigating to a video.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Audio/Video: Playback' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Selim Şumlu]

I can reproduce this by just pressing the "F" key to go full screen.

Comment 4

[Geoff Lankow (:darktrojan) [PTO, back 28/4]]

When you click on a thumbnail link to a video on YouTube, the page is updated (no new document is loaded) and the link elements get recycled (the same elements reappear somewhere else on the page later). So I think it's quite likely the same problem as bug 1767515.

I see this a lot, and I think it's become more frequent in recent weeks. (Possibly something to do with YouTube versus the ad blockers, I use uBO.) IME there's no need to go full-screen or theatre mode, just click on any video. Rolling over any other link clears the panel.

Comment 7

[Dão Gottwald [:dao]]

Attachment: Bug 1850993 - Clear status panel when entering DOM Fullscreen. r=gijs

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c08947fa1435
Clear status panel when entering DOM Fullscreen. r=Gijs

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 9365225 [details]
Bug 1850993 - Clear status panel when entering DOM Fullscreen. r=gijs

Beta/Release Uplift Approval Request

• User impact if declined: subpar user experience e.g. for watching video (I'm told American Football streaming season in particular makes this a current priorty, even to the point where we should consider it for the next dot release)
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: see comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): pretty straightforward & small patch
• String changes made/needed:
• Is Android affected?: No

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c08947fa1435

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/e57ee6ee3f5e

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9365225 [details]
Bug 1850993 - Clear status panel when entering DOM Fullscreen. r=gijs

Approved for 121.0b4.

Comment 13

[Adrian Florinescu [:aflorinescu] [PTO until 04.23 ]]

Verified as fixed with 122.0a1 (2023-11-27) and 121.0b4 on Ubuntu 22, win10, Mac 13.

To my understanding, the fix ensures the URL status bar gets hidden once user enters full screen, which is what is also verified with the above.
The patch doesn't do anything in regards to the persistence of the URL status bar once a video is opened from the youtube homepage with the given STR (1-4). Please note that navigating from one loaded video to another video is not persisting the URL status bar, which I think it's the expected result.
Dao, thoughts on the STR(1-4) behavior - is there any reason for which the URL status bar should be persisted in that case?

Comment 14

[Dão Gottwald [:dao]]

(In reply to Adrian Florinescu [:aflorinescu] from comment #13)

Verified as fixed with 122.0a1 (2023-11-27) and 121.0b4 on Ubuntu 22, win10, Mac 13.

To my understanding, the fix ensures the URL status bar gets hidden once user enters full screen, which is what is also verified with the above.
The patch doesn't do anything in regards to the persistence of the URL status bar once a video is opened from the youtube homepage with the given STR (1-4). Please note that navigating from one loaded video to another video is not persisting the URL status bar, which I think it's the expected result.
Dao, thoughts on the STR(1-4) behavior - is there any reason for which the URL status bar should be persisted in that case?

No, it shouldn't persist, but if it did let's treat that as a separate bug. Like you said we're only concerned with entering fullscreen mode here.

Comment 15

[Adrian Florinescu [:aflorinescu] [PTO until 04.23 ]]

Given comment 13 / comment 14, I'll mark this as verified and update flags, please readd qe+ flag if we want to uplift in 120 dot.

Comment 17

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/dd3606c60f41

Comment 18

[Dianna Smith [:diannaS]]

Comment on attachment 9365225 [details]
Bug 1850993 - Clear status panel when entering DOM Fullscreen. r=gijs

Approved for 120.0.1 dot release