Closed Bug 1858041 Opened 2 years ago Closed 1 year ago

[meta] Multiple tier 2 failures happening on a11y-checks

Categories

(Core :: Disability Access APIs, defect, P2)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: noriszfay, Assigned: ayeddi)

References

(Blocks 2 open bugs)

Details

(Keywords: intermittent-failure, meta, Whiteboard: [stockwell unknown])

Attachments

(5 files)

Multiple accessibility tier 2 failures caused by the following push on M-a11y-checks & M-swr-a11y-checks with some of them being perma.

Failures seen here.

Flags: needinfo?(ayeddi)

The Bugbug bot thinks this bug should belong to the 'Core::Disability Access APIs' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: General → Disability Access APIs
Product: Firefox → Core
Depends on: 1858037
Assignee: nobody → ayeddi
Blocks: 1692110
Severity: -- → S4
Flags: needinfo?(ayeddi)
Priority: -- → P2
See Also: → 1854228, 1849021, 1855491

We are working on enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to expect to be failing these tests altogether and then handle each one of them individually.

This task is to expect failing of these tests with fail-if condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved.

Related bugs:

Pushed by ayeddi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9dc8d4452ed5 Temporarily fail-if some Tier 2 a11y_checks failing on Autoland. r=Jamie,devtools-reviewers,mixedpuppy,nchevobbe
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
Duplicate of this bug: 1858523
Duplicate of this bug: 1858554
Duplicate of this bug: 1858560
Duplicate of this bug: 1858563
Duplicate of this bug: 1858564
Duplicate of this bug: 1858490

hello Anna, could you take a look at these remaining tier 2 bugs that still linger on autoland? Thank you!

Flags: needinfo?(ayeddi)
Duplicate of this bug: 1858493
Duplicate of this bug: 1858587
Status: RESOLVED → REOPENED
Keywords: leave-open
Resolution: FIXED → ---
Target Milestone: 120 Branch → ---
Duplicate of this bug: 1858489

(In reply to Norisz Fay [:noriszfay] from comment #13)

hello Anna, could you take a look at these remaining tier 2 bugs that still linger on autoland? Thank you!

Will write a patch today, thank you for the link!

Duplicate of this bug: 1858475

There are some a11y_checks that are intermittently failing on Autoland and pass on Try and vice versa. Also, a couple of tests are crashing while performing a11y_checks, thus they are to be skipped while we continue the investigation into each of them.

Related bugs:

Attachment #9358213 - Attachment description: Bug 1858041 - Temporarily skip of fail-if some Tier 2 a11y_checks failing or crashing on Autoland. r=Jamie → Bug 1858041 - Temporarily skip of fail-if some Tier 2 a11y_checks failing or crashing on Autoland. r=Jamie,ochameau,#extension-reviewers,#fxview-reviewers,#devtools-reviewers
Attachment #9358213 - Attachment description: Bug 1858041 - Temporarily skip of fail-if some Tier 2 a11y_checks failing or crashing on Autoland. r=Jamie,ochameau,#extension-reviewers,#fxview-reviewers,#devtools-reviewers → Bug 1858041 - Temporarily skip of fail-if some Tier 2 a11y_checks failing or crashing on Autoland. r=Jamie
Pushed by ayeddi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/746ba32c4a02 Temporarily skip of fail-if some Tier 2 a11y_checks failing or crashing on Autoland. r=Jamie,fxview-reviewers,ochameau,devtools-reviewers,places-reviewers,mixedpuppy

There are some a11y_checks that are intermittently failing on Autoland and pass on Try and vice versa. Also, a couple of tests are crashing while performing a11y_checks, thus they are to be skipped while we continue the investigation into each of them.

Related bugs:

Attachment #9359008 - Attachment description: Bug 1858041 - Pt.3. Temporarily skip some Tier 2 a11y_checks for unexpecredly failing/passing or crashing on Autoland. r=Jamie → Bug 1858041 - Pt.3. Temporarily skip some Tier 2 a11y_checks for unexpecredly failing/passing or crashing on Autoland. r=Jamie,rpl
Attachment #9359008 - Attachment description: Bug 1858041 - Pt.3. Temporarily skip some Tier 2 a11y_checks for unexpecredly failing/passing or crashing on Autoland. r=Jamie,rpl → Bug 1858041 - Pt.3. Temporarily skip some Tier 2 a11y_checks for unexpecredly failing/passing or crashing on Autoland. r=Jamie

Hi Joel. Do you have any idea why a11y-checks jobs would be running on Mac (example)? As I understand it, they should only be running on Linux as tier 2 at this stage. The eventual goal is to run them on all platforms, but we're not there yet, so this was surprising to us.

Flags: needinfo?(jmaher)

that was added with the add-new action, which allows you to add all kinds of things, even if they are not supported. In this case you could add it for linux, windows, mac, but not android because android doesn't run any browser-chrome tests.

There is no default scheduling or other ways to make this work, so I think you are ok.

Flags: needinfo?(jmaher)
See Also: → 1854647
Pushed by ayeddi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f222bdcd6517 Pt.3. Temporarily skip some Tier 2 a11y_checks for unexpecredly failing/passing or crashing on Autoland. r=Jamie,extension-reviewers,devtools-reviewers,rpl,places-reviewers
Flags: needinfo?(ayeddi)
See Also: → 1857056
See Also: → 1824058
Duplicate of this bug: 1860720
See Also: → 1861277
See Also: → 1860873
See Also: → 1849179
See Also: → 1854536
Blocks: 1854537
See Also: → 1854460
Blocks: 1854461
Duplicate of this bug: 1860775
No longer duplicate of this bug: 1860775
Flags: needinfo?(ayeddi)

There are some a11y_checks that are intermittently failing on Autoland and pass on Try and vice versa. Also, a couple of tests are crashing while performing a11y_checks, thus they are to be skipped while we continue the investigation into each of them.

Related bugs:

Blocks: 1854661
Pushed by ayeddi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/53b8e85e4486 Pt.4. Temporarily skip some Tier 2 a11y_checks for unexpecredly failing/passing or crashing on Autoland. r=devtools-reviewers,credential-management-reviewers,issammani
See Also: → 1862417

Hey Anna, could you take a look at these tests too? It seems a few are still remaining here and there such as: browser_panelUINotifications_multiWindow.js, browser_doorhanger_installs.js.

Flags: needinfo?(ayeddi)
Duplicate of this bug: 1861497
Blocks: 1863584
Depends on: 1863815

(In reply to Norisz Fay [:noriszfay] from comment #52)

Hey Anna, could you take a look at these tests too? It seems a few are still remaining here and there such as: browser_panelUINotifications_multiWindow.js, browser_doorhanger_installs.js.

Thank you, Norisz!

I filed a separate bug 1863815 to fix the browser_panelUINotifications_multiWindow.js failure and the patch for it is under the review.

I could not find any new instanced of the browser_doorhanger_installs.js failing, but I keep tracking the failures across the board. If there won't be any new failure, I'll close this bug when the bug 1863815 is closed too. Unless there would new failures appear...

Flags: needinfo?(ayeddi)
See Also: → 1864226

Hey Anna, this failure seems to be lingering around recently, could you take a look please? Thank you! Failure log here

Flags: needinfo?(ayeddi)

(In reply to Norisz Fay [:noriszfay] from comment #63)

Hey Anna, this failure seems to be lingering around recently, could you take a look please? Thank you! Failure log here

Hey Norisz, I just pushed the WIP patch for these few tests to Try - I'll be adding this as a part 2 patch for the bug 1863584 since these tests were reenabled in there but not fail-ifed. They used to just crash, so it was not clear if they could be failing or not.

Thank you for bringing them up!

Flags: needinfo?(ayeddi)

Some "new" failure seems to have appeared as can be seen here, could you take a look please? Thank you! Log here.

Flags: needinfo?(ayeddi)
See Also: → 1802390

Hey Anna, any chance you could take a look at this one too? Thank you! Log here

Duplicate of this bug: 1866232

(In reply to Norisz Fay [:noriszfay] from comment #69)

Hey Anna, any chance you could take a look at this one too? Thank you! Log here

Thank you, Norisz! Opening that one now - it looks like the failures were fixed, which is great news :)

Flags: needinfo?(ayeddi)
See Also: → 1866843
See Also: → 1866598
Depends on: 1867170
Duplicate of this bug: 1867062

Since the major accessibility remediation work is on the way, one more test is now passing the Tier 2 a11y-checks, thus we are removing the fail-if condition from its manifest to allow for the test harness to expect appropriate results (passing).

Related bugs: bug 1849028, bug 1867062

Attachment #9366920 - Attachment description: WIP: Bug 1858041 - [devtools] Remove `fail-if` from the browser_webconsole_longstring_getter.js test that is passing a11y-cheks → Bug 1858041 - [devtools] Remove `fail-if` from the browser_webconsole_longstring_getter.js test that is passing a11y-cheks
Attachment #9366920 - Attachment description: Bug 1858041 - [devtools] Remove `fail-if` from the browser_webconsole_longstring_getter.js test that is passing a11y-cheks → Bug 1858041 - [devtools] Remove `fail-if` from two mochitests that are passing a11y-cheks
Attachment #9366920 - Attachment description: Bug 1858041 - [devtools] Remove `fail-if` from two mochitests that are passing a11y-cheks → Bug 1858041 - [devtools] Remove `fail-if` from one mochitest that is passing a11y-checks and add `skip-if` to one with inconsistent results. r=nchevobbe
Blocks: 1868497
Attachment #9366920 - Attachment description: Bug 1858041 - [devtools] Remove `fail-if` from one mochitest that is passing a11y-checks and add `skip-if` to one with inconsistent results. r=nchevobbe → Bug 1858041 - [devtools] Replace `fail-if` with `skip-if` for 2 tests that inconsistently failing/passing a11y-checks. r=nchevobbe
Pushed by ayeddi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/16386070090d [devtools] Replace `fail-if` with `skip-if` for 2 tests that inconsistently failing/passing a11y-checks. r=devtools-reviewers,nchevobbe
Whiteboard: [stockwell disable-recommended] → [stockwell needswork:owner]
See Also: → 1872899

It's been a while since any unexpected a11y-checks were failing for the pre-existent (before Oct 2023) tests, so I'm closing this bug for now.

Feel free to reopen it, if there are any new concerns.

Status: REOPENED → RESOLVED
Closed: 2 years ago1 year ago
Keywords: leave-open
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: