1863584 - Remove skip-if for a11y_checks that previously crashed with @ mozilla::detail::InvalidArrayIndex

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task, P3)

Description

[Anna Yeddi [:ayeddi] ⚠️ Online half days through May 23]

We had to skip-if those tests that were crashing during a11y_checks and since the bug 1849230 is resolved now these test can be re-enabled

Comment 1

[Anna Yeddi [:ayeddi] ⚠️ Online half days through May 23]

Tests affected:

1. Bookmarks & History (only crashed): browser/components/places/tests/browser/browser_toolbar_drop_bookmarklet.js
2. Search and Address Bar (failed too, tracked in bug 1854661): browser/components/urlbar/tests/browser/browser_searchMode_setURI.js
3. Desktop Firefox (only crashed): toolkit/components/printing/tests/browser_print_margins.js
4. Devtools (tracked Bug in 1849028):
   1. devtools/client/debugger/test/mochitest/browser_dbg-breakpoints-list.js
   2. devtools/client/debugger/test/mochitest/browser_dbg-features-source-tree.js
   3. devtools/client/debugger/test/mochitest/browser_dbg-sourcemapped-scopes.js (also had intermittent pass/fails on Try and Autoland, tracked in bug 1849028)
   4. devtools/client/framework/test/browser_toolbox_meatball.js
   5. devtools/client/inspector/rules/test/browser_rules_color_scheme_simulation.js
   6. devtools/client/inspector/rules/test/browser_rules_color_scheme_simulation_bfcache.js
   7. devtools/client/inspector/rules/test/browser_rules_css-compatibility-toggle-rules.js
   8. devtools/client/webconsole/test/browser/browser_webconsole_console_logging_workers_api.js
   9. devtools/client/webconsole/test/browser/browser_webconsole_context_menu_copy_message_with_async_stacktrace.js
   10. devtools/client/webconsole/test/browser/browser_webconsole_split_persist.js

Comment 2

[Anna Yeddi [:ayeddi] ⚠️ Online half days through May 23]

Attachment: Bug 1863584 - Remove skip-if for a11y_checks that previously crashed with @ mozilla::detail::InvalidArrayIndex

We had to skip-if those tests that were crashing during a11y_checks and since the bug 1849230 is resolved now these test can be re-enabled (whenever possible). Two tests have also been failing intermittently, thus they are remaining skipped, but the comment is updated to remove the mention of the crash.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3ce0b882353
Remove skip-if for a11y_checks that previously crashed with @ mozilla::detail::InvalidArrayIndex r=Gijs,Standard8

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f3ce0b882353

Comment 5

[Anna Yeddi [:ayeddi] ⚠️ Online half days through May 23]

I'll be adding the fix for these few tests failing now as a part 2 patch for the bug 1863584 since these tests were re-enabled in here but not fail-ifed. They used to just crash, so it was not clear if they could be failing or not.

Tests in question:

1. TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-breakpoints-list.js | Node is not accessible via accessibility API: id: , tagName: DIV, className: CodeMirror-linenumber CodeMirror-gutter-elt -
2. TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-features-source-tree.js | Node is not focusable via the accessibility API: id: server0.conn0.windowGlobal281320357889/thread1|example.com|/browser/devtools/client/debugger/test/mochitest/examples, tagName: DIV, className: tree-node -
3. TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-features-source-tree.js | Node is not focusable via the accessibility API: id: server0.conn0.windowGlobal283467841537/thread1|example.com|/browser/devtools/client/debugger/test/mochitest/examples, tagName: DIV, className: tree-node -
4. TEST-UNEXPECTED-FAIL | devtools/client/inspector/flexbox/test/browser_flexbox_container_and_item_accordion_state.js | Node is not accessible via accessibility API: id: , tagName: div, className: html-arrowscrollbox-inner -
5. TEST-UNEXPECTED-FAIL | devtools/client/inspector/rules/test/browser_rules_css-compatibility-toggle-rules.js | Node is not focusable via the accessibility API: id: , tagName: input, className: ruleview-enableproperty -

Comment 6

[Anna Yeddi [:ayeddi] ⚠️ Online half days through May 23]

Attachment: Bug 1863584 - Pt.2. Add fail-if for previously crashing a11y_checks that were re-enabled. r=Jamie

These tests are now enabled but are failing (instead of crashing), thus adding fail-if notations to their mantifests.

devtools/client/debugger/test/mochitest/browser_aj.toml HG: changed
devtools/client/inspector/rules/test/browser_part2.toml

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba76e04c959a
Pt.2. Add fail-if for previously crashing a11y_checks that were re-enabled. r=Jamie,devtools-reviewers,nchevobbe

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ba76e04c959a