1854460 - Temporarily disable some Tier 2 a11y_checks for Webextensions

Status: RESOLVED FIXED

(WebExtensions :: Frontend, task, P3)

Description

[Anna Yeddi [:ayeddi]]

We are working on enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to skip the failing tests altogether and then handle each one of them individually.

This task is to skip with fail-if condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved. A separate task to investigate the failed Tier 2 a11y_checks will be filed for an appropriate component.

Tests affected:

FAIL	browser/components/extensions/test/browser/browser_ext_browserAction_disabled.js	Node is enabled but disabled via the accessibility API	_afdfcbb6-9280-4990-99ed-890b387d6ee4_-BAP	toolbarbutton	unified-extensions-item-action-button toolbarbutton-1 panel-no-padding webextension-browser-action
FAIL	browser/components/extensions/test/browser/browser_ext_browserAction_disabled.js	Node is not focusable via the accessibility API	_afdfcbb6-9280-4990-99ed-890b387d6ee4_-BAP	toolbarbutton	unified-extensions-item-action-button panel-no-padding webextension-browser-action subviewbutton subviewbutton-iconic
FAIL	browser/components/extensions/test/browser/browser_ext_browserAction_disabled.js	Node is enabled but disabled via the accessibility API	_afdfcbb6-9280-4990-99ed-890b387d6ee4_-BAP	toolbarbutton	unified-extensions-item-action-button panel-no-padding webextension-browser-action subviewbutton subviewbutton-iconic
FAIL	browser/components/extensions/test/browser/browser_ext_browserAction_popup_preload.js	Node is not accessible via accessibility API		html:body	
FAIL	browser/components/extensions/test/browser/browser_ext_browserAction_popup_preload.js	Node is enabled but disabled via the accessibility API	_2ede3b3d-5821-4f4d-b1e3-7c4cee52bc0e_-BAP	toolbarbutton	unified-extensions-item-action-button toolbarbutton-1 panel-no-padding webextension-browser-action
FAIL	browser/components/extensions/test/browser/browser_ext_menus_capture_secondary_click.js	Node is not focusable via the accessibility API	_78f1afd6-9059-4e04-a114-6f8c35bbdb79_-menuitem-94	menuitem	
FAIL	browser/components/extensions/test/browser/browser_ext_menus_capture_secondary_click.js	Node is enabled but disabled via the accessibility API	_78f1afd6-9059-4e04-a114-6f8c35bbdb79_-menuitem-94	menuitem	
FAIL	browser/components/extensions/test/browser/browser_unified_extensions.js	Node is not accessible via accessibility API		browser	

Jobs affected:

1. test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-a11y-checks-${1-7} (Try run)

---

Some Tier 2 accessibility checks for click events fired on controls that should be keyboard accessible and have valid labels were failing for this component. They were captured by testing/mochitest/tests/SimpleTest/AccessibilityUtils.js via bug 1692110. These failing tests should be temporarily skipped in the directory's browser.ini file while we investigate these failures. For all confirmed bugs individual defects should be filed.

When the individual test failures are resolved and the individual bugs are closed, remove the fail-if condition for a11y_checks from the appropriate files/sections to ensure better test coverage and to avoid regressions in a11y of these components.

Comment 1

[Anna Yeddi [:ayeddi]]

Attachment: Bug 1854460 - Temporarily fail-if some Tier 2 a11y_checks for Webextensions. r=mixedpuppy,Jamie

We are working on enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to skip the failing tests altogether and then handle each one of them individually.

This task is to skip with fail-if condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved.

Related bugs:

• Disabling tests: meta bug 1848402
• Investigation and remediation for components with disabled tests: meta bugs 1848394 and 1854227, Webextensions-sepecific meta bug 1854461
• Explore capturing click events for a11y_checks: bug 1692110

Depends on D188912

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37c2ec0851dc
Temporarily disable some Tier 2 a11y_checks for Webextensions. r=mixedpuppy

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/37c2ec0851dc

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out for causing multiple tier 2 failures on
Backout link
Push with failures

https://bugzilla.mozilla.org/show_bug.cgi?id=1857672
https://bugzilla.mozilla.org/show_bug.cgi?id=1857666
https://bugzilla.mozilla.org/show_bug.cgi?id=1857664
https://bugzilla.mozilla.org/show_bug.cgi?id=1857665
https://bugzilla.mozilla.org/show_bug.cgi?id=1857707

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/041f945660d1
Temporarily fail-if some Tier 2 a11y_checks for Webextensions. r=mixedpuppy

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/041f945660d1