1854836 - Search results pane is too small

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Dr B W Darvell]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/117.0

Steps to reproduce:

Ctrl-Shift-F
search anything
try to resize the results pane

Actual results:

The pane is limited in its upper extent to no more than about half of the window, leaving room for up to about 20 search terms! - A trifle excessive as a default space.

Expected results:

Allow the upper margin to be dragged to the fullest extent.
However, it can be dragged down to show just one line.
(BTW: the border moves at HALF the rate of the cursor! Bizarre.)

Comment 1

[Anje]

Using beta 118.0b6

Confirm. I see the same. This is reproduceable.

Actual results:
AS you enlarge the height of the window, the margin between top search criteria and search results auto lowers thus increasing the area containing search criteria.
Search parameter area is half the screen, so if only a couple of search criteria is used, it means there is a huge amount of vacant space before the actual search results list below.
Impossible to raise the splitter top of search list zone in order to allow more search results to be shown.

Expected:
A single extra vacant line below the search criteria, then the splitter followed by list of search results.
When increasing height of window to display more search results, the splitter should remain in same location and the search list area should increase in height, thus displaying more results.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Bug 1854836 - Make the message search dialog flex better. r=#thunderbird-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a134994c4b8b
Make the message search dialog flex better. r=mkmelin

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 9356006 [details]
Bug 1854836 - Make the message search dialog flex better. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): new flexbox implementation
User impact if declined: not well flexing boxes in message search dialog
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Magnus Melin [:mkmelin]]

This seems to have upset comm/mail/base/test/browser/browser_searchMessages.js on windows - https://treeherder.mozilla.org/jobs?repo=comm-central&selectedTaskRun=c4Cad65sSGSaSV43uf1teQ.0 (where it's a new perma orange). Other platforms are ok.

Comment 6

[Richard Marti (:Paenglab)]

Hmm tested it locally and it doesn't fail. I see the search dialog is filled with messages and two filter values.

Comment 7

[Geoff Lankow (:darktrojan)]

I know what's wrong. I had to insert a hack in this test to make it work on the CI. It looks like you've fixed the problem but annoyed the hack. Checking to see how much of it I can remove.

Comment 8

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1854836 - Remove hack in browser_searchMessages.js. r=#thunderbird-reviewers

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cac37c91a6a2
Remove hack in browser_searchMessages.js. r=aleca

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9356006 [details]
Bug 1854836 - Make the message search dialog flex better. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 11

[Daniel Darnell [:dandarnell]]

Thunderbird 119.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/4e3cddc56c9e

Comment 12

[Magnus Melin [:mkmelin]]

I think you want the follow-up too, from comment 9 (or tests will fail).

Comment 13

[Daniel Darnell [:dandarnell]]

(In reply to Magnus Melin [:mkmelin] from comment #12)

I think you want the follow-up too, from comment 9 (or tests will fail).

That test (or at least a file named browser_searchMessages.js at that location) does not seem to exist in comm-beta, which is why I skipped the uplift.

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9356006 [details]
Bug 1854836 - Make the message search dialog flex better. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Comment 15

[Rob Lemley [:rjl]]

Thunderbird 115.3.2:
https://hg.mozilla.org/releases/comm-esr115/rev/4e717beddb56
https://hg.mozilla.org/releases/comm-esr115/rev/132d475274d2