1855471 - Stop using deprecated message-bar element for outstanding shopping message bars

Status: RESOLVED FIXED

(Firefox :: Shopping, task)

Description

[Hanna Jones [:hjones]]

Bug 1844783 handled updating most of the message bars in the shopping sidebar to use the new moz-message-bar component, but there were a few cases that the new component doesn't support yet that we decided to split out for later. Specifically we still need to address:

• the "stale" message bar (moz-message-bar doesn't support removing the background color)
• the "analysis-in-progress" message bar (moz-message-bar doesn't support changing the icon + the blue loading spinner would be less visible on the blue message bar background, which is the new color for our "informational" message bar variant)
• the "reanalysis-in-progress" message bar (has both of the issues listed above)

Before we can replace these message bars some collaboration needs to happen between the shopping and recomp teams to decide if we need to tweak the designs slightly, or if we want to modify moz-message-bar to support some of these use cases.

Comment 1

[Hanna Jones [:hjones]]

Attachment: Bug 1855471 - Replace last <message-bar> instances with <div>s r=#shopping-reviewers

The <shopping-message-bar> component is the last place we're using the deprecated <message-bar> component. As such, it's the one thing standing preventing us from remvoing the old <message-bar> implementation (see Bug 1845151). I took a quick look and the <message-bar>s here aren't actually providing any styling/layout and seem to be easily replacable with <div>s.

Comment 2

[Hanna Jones [:hjones]]

At this point we don't want to support some kind of un-styled variant of moz-message-bar, which is what we would need if we wanted to replace these simple text or text + button combos with that component. The fact that the styling can be preserved just by wrapping these "message bars" in a <div> suggests that they don't really need to use a custom element at all. For the sake of being able to fully remove the older message-bar element I'm changing the scope of this bug slightly.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a6af72177a3
Replace last <message-bar> instances with <div>s r=shopping-reviewers,Gijs

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9a6af72177a3