1888466 - Unmerge "Browsing & Download History" and "Form & Search History" in the new Clear Data/History dialog

Status: RESOLVED FIXED

(Toolkit :: Data Sanitization, enhancement, P3)

Description

[aoia7rz7l]

The "new" Clear Data/History dialog has merged "Browsing & Download History" and "Form & Search History" into a single option, UI-wise in Bug 1856415 and pref-wise in Bug 1861450 (Apparently there was some effort to re-separate "Download History" at one point but I am not sure that's too relevant here).

Why is this a good idea?

If you look under about:preferences#privacy >History > Use custom settings for history, you can see there are separate options for Remember browsing and download history (which controls places.history.enabled) and Remember search and form history (which controls browser.formfill.enable). How are users supposed to clear one thing but not the other with this "new" dialog?

I was going to say that this is another "chrome-parity" thing but when I actually booted up chrome, they do have a "Autofill form data" clearing option separate from "Browsing history", so I have absolutely no idea what's going on here.

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Search' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Harshit Sohaney [:hsohaney]]

I can see how the new dialog has removed this functionality, and I would recommend switching back to the old dialog if this is a real pain point right now. We will consider adding a separate option in a later version of this dialog, and until then, you can keep the pref privacy.sanitize.useOldClearHistoryDialog set to true.

Comment 3

[Emma Zühlcke [:emz]]

If we do decide to split those options up again I think they should be in an "advanced" view which offers more fine grained control.

Comment 4

[08xjcec48]

On Nightly, the advanced/custom history clearing options in about:preferences#privacy also use the new dialog by default now. According to the reporter, they didn't when this issue was filed.

The new design looks nicer and is easier to understand, but instead of merging Browsing/Download/Form, I'd rather separate Browsing from Download too.

Users very often create forum threads asking us how to delete form entries. After just a few days of browsing, they may include dozens of strings we have no use for, including misspellings and very specific search queries. People appreciate it when we tell them that they can set Firefox to clear those entries automatically.

Unlike the menu that only clears your recent history, this specific dialog is usually only seen once in a lifetime. Please don't simplify it to the point of removing a feature that is essential for us.

Comment 5

[08xjcec48]

I've found out that this isn't just a GUI change. It also uses a new unified prefs.js entry for browsing, download, and form history, so if you end up leaving it like this, and then remove privacy.sanitize.useOldClearHistoryDialog later on, we won't even be able to use about:config to set it to clear only form entries.

Edge has a very nice "Clear browsing data on close" page with separate options for everything. It also allows users to set cookie clearing exceptions from the same page.

Comment 6

[Marco Bonardo [:mak]]

(In reply to 08xjcec48 from comment #4)

I'd rather separate Browsing from Download too.

That'd be complex to do, and confusing, because downloads are browsing history. Thus removing browsing history should also always remove downloads, or it would be a privacy hit (Edge is likely not minding these privacy subtleties). Removing downloads without removing history is instead already possible from the Library window. But showing that kind or hierarchy in a dialog would be, imo, very confusing for the user.

Comment 7

[08xjcec48]

My point is that, in my opinion, it would make more sense to add new granular options instead of removing Form & search history.

Anyway, this is what the addition of a new "Downloads" toggle could look like:

[ ] Browsing history and downloads
[x] Downloads 

Result: it performs the same action that Clear Downloads does in the Library window.

[x] Browsing history and downloads

Result: the separate Downloads item is automatically checked too and grayed-out.

Comment 8

[Marco Bonardo [:mak]]

(In reply to 08xjcec48 from comment #7)

[x] Browsing history and downloads

Result: the separate Downloads item is automatically checked too and grayed-out.

Me and you understand that... unfortunately many users would wonder why it's disabled, and we'd get bugs on file for it.
Surely one could indent downloads under browsing history, but I still don't see a strong use-case into clearing downloads but not history, from a privacy point of view.
That said, this is matter for UX, more than engineering.

Comment 9

[Dan [:dan23]]

(In reply to 08xjcec48 from comment #5)

if you end up leaving it like this, and then remove privacy.sanitize.useOldClearHistoryDialog later on, we won't even be able to use about:config to set it to clear only form entries.

Or on the other hand, only site and download history, without clearing form entries.

Comment 10

[08xjcec48]

This is the current top thread on the Firefox subreddit: Mozila needs to learn that Chrome's UI/UX is not the "correct UI" for a browser.

Comment 11

[Dan [:dan23]]

Wow, good, more users are tuning in! Great post by "fsau" there too.

Comment 12

[08xjcec48]

To the developer who hid my last comment: there's no "advocacy" in sharing a relevant forum thread with the opinions of many users.

Such links are usually added to the "See also" field of issues so that other developers and Mozilla product managers may become aware that a feature is actually useful for people, especially when the Bugzilla issue in question is a discussion where you've said that you aren't sure if you should add an option back to Firefox.

Please remove the "advocacy" tag from my comment, add that link to the "See also" field of this issue, and also add this other link: https://connect.mozilla.org/t5/discussions/128-0-unified-history-simpler-but-worse/td-p/61902 .

Comment 13

[Dan Mehic]

We're aware and appreciative of all the feedback.

Comment 14

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1888466 - (Part 1) Unmerge form data from the history and downloads pref. r?manuel

Comment 15

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1888466 - (part 2) Add a separate formdata field and preference in the new clear history dialog. r?manuel

Comment 16

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1888466 - (part 3) Update clear history dialog tests to reflect browsing history and formdata separation. r?manuel

Comment 17

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1888466 - (part 6) Update policies to split formdata from history. r?manuel

Comment 18

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1888466 - (part 5) Fix the browser_sanitize-formhistory test to test using the relevant cleaners. r?manuel

Comment 20

[Harshit Sohaney [:hsohaney]]

I'm a little confused, I was still working on this. Were there internal requests to complete this quicker? I have some updates to the patches, should I abandon that work?
I was about to submit some updates to the patches in the next two days since I finally got some time during reading week, let me know

Comment 21

[William Wen (:wwen)]

Oops our bad, there was a request for a new owner on this bug a couple of weeks ago and I just got around to working on it. If you are still working on it and have patches to submit then you can re commandeer the patches and carry on.

Comment 22

[Harshit Sohaney [:hsohaney]]

Alright, I'll submit them soon!

Comment 23

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1888466 - (part 4) Update glean telemetry to include form data for the new clear history dialog. r?pbz

Comment 24

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1888466 - (part 4) Update glean telemetry to include form data for the new clear history dialog. r?pbz

Comment 25

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1888466 - (part 4) Update glean telemetry to include form data for the new clear history dialog. r?pbz

Comment 26

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1888466 - (part 4) Update glean telemetry to include form data for the new clear history dialog. r?pbz

Comment 27

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1888466 - (part 4) Update glean telemetry to include form data for the new clear history dialog. r?pbz

Comment 28

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1888466 - (part 4) Update glean telemetry to include form data for the new clear history dialog. r?pbz

Comment 29

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1888466 - (part 4) Update glean telemetry to include form data for the new clear history dialog. r?manuel

Comment 30

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1888466 - (part 4) Update glean telemetry to include form data for the new clear history dialog. r?pbz

Comment 31

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1888466 - (part 7) Add a migration to allow user's to continue clearing data without any unexpected data loss or persistance for history and formdata. r?manuel

Comment 32

[Dan Mehic]

Hi Harshit, thanks again for working on this. Do you think you'll have the bandwidth to drive this to completion before end of the year?

Comment 33

[Manuel Bucher [:manuel]]

Paul mentioned in team meeting that this is currently mostly blocked on his review and asked if someone could help out. I'll take a look at the patches and plan to review this week.

Comment 34

[Manuel Bucher [:manuel]]

Attachment: input_from_ux.png

Attaching input from ux team to bug (to have it visible outside phabricator).

Comment 35

[Manuel Bucher [:manuel]]

Hi, thanks for patiently updating the patches. I think it would be better to wait with landing until Nightly 116, because I'm on PTO from tomorrow (and it is weekend) until the soft code freeze for Fx115 starts (And I don't believe it's too urgent to land today).

Comment 36

[Harshit Sohaney [:hsohaney]]

That sounds good to me. Thanks for the reviews and enjoy your PTO!!

Comment 37

[Dan [:dan23]]

(In reply to Manuel Bucher [:manuel] {{ PTO Dec 21 - Jan 1 }} from comment #35)

Hi, thanks for patientially updating the patches. [...]

*patiently, not "patientially", afaik. :P enjoy your holiday!!

Comment 38

[Harshit Sohaney [:hsohaney]]

Hey Manuel, I wanted to clarify which version this was to be landed in

Comment 39

[Manuel Bucher [:manuel]]

Targeting to land after code freeze in few hours (or tomorrow) Fx136.

Comment 40

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/108890d1478a
(Part 1) Unmerge form data from the history and downloads pref. r=fluent-reviewers,bolsson,manuel
https://hg.mozilla.org/integration/autoland/rev/87ceb9a20ff8
(part 2) Add a separate formdata field and preference in the new clear history dialog. r=fluent-reviewers,bolsson,manuel
https://hg.mozilla.org/integration/autoland/rev/73df8c9929ba
(part 3) Update clear history dialog tests to reflect browsing history and formdata separation. r=emz,cookie-reviewers,places-reviewers,mconley,manuel
https://hg.mozilla.org/integration/autoland/rev/b0b5de465672
(part 4) Update glean telemetry to include form data for the new clear history dialog. r=manuel
https://hg.mozilla.org/integration/autoland/rev/e04e09f6fceb
(part 5) Fix the browser_sanitize-formhistory test to test using the relevant cleaners. r=emz,manuel
https://hg.mozilla.org/integration/autoland/rev/6171109790bc
(part 6) Update policies to split formdata from history. r=manuel
https://hg.mozilla.org/integration/autoland/rev/1d40063a5fe7
(part 7) Add a migration to allow user's to continue clearing data without any unexpected data loss or persistance for history and formdata. r=manuel

Comment 41

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/108890d1478a
https://hg.mozilla.org/mozilla-central/rev/87ceb9a20ff8
https://hg.mozilla.org/mozilla-central/rev/73df8c9929ba
https://hg.mozilla.org/mozilla-central/rev/b0b5de465672
https://hg.mozilla.org/mozilla-central/rev/e04e09f6fceb
https://hg.mozilla.org/mozilla-central/rev/6171109790bc
https://hg.mozilla.org/mozilla-central/rev/1d40063a5fe7

Comment 42

[Manuel Bucher [:manuel]]

Do you mind requesting release notes? I think this is a somewhat anticipated change by the community and would benefit from being mentioned. I can also do the requesting if you prefer.

Comment 43

[Harshit Sohaney [:hsohaney]]

Attachment: New dialog screenshot

Comment 44

[Harshit Sohaney [:hsohaney]]

Release Note Request (optional, but appreciated)
[Why is this notable]: Much requested change since the new clear history dialog shipped
[Affects Firefox for Android]: No
[Suggested wording]: The new clear data dialog allows clearing form data separately from browsing history.
[Links (documentation, blog post, etc)]:
Attached new dialog image New dialog screenshot