1857114 - Update the icon in addon rows

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

Per Josh on Slack, the icon in addon rows is too big. The Figma shows the icon at 24x24px insde a larger gray 60x60px box.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1857114 - Update the icon in addon rows.

These rules are similar to the Pocket ones because the UI is similar: A 24x24px
icon inside a larger gray box.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29d9ef63aed0
Update the icon in addon rows. r=daisuke,desktop-theme-reviewers,dao

Comment 3

[Drew Willcoxon :adw]

Attachment: Screenshot of expected addons icon

Comment 4

[Drew Willcoxon :adw]

For QA, please see the screenshot in the previous comment of what the addons icon should look like. The Figma is here. The icon should be inside a larger gray box, similar to Pocket suggestions.

Edit: The gray box in that screenshot is slightly smaller than what you might see because I made it with the fix to bug 1857137 also applied. That's fine, the important thing is the particular addon icon should be inside the gray box. (The difference is 52px (with bug 1857137 applied) vs. 60px (without bug 1857137 applied))

Comment 5

[Drew Willcoxon :adw]

Comment on attachment 9356747 [details]
Bug 1857114 - Update the icon in addon rows.

Beta/Release Uplift Approval Request

• User impact if declined: This is a nice-to-have. It changes the look of the icon for addon suggestions in the urlbar to better match the intended UX. Addon suggestions are enabled for U.S. users starting in 118. They are disabled for everyone else.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Please see previous comment
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a CSS-only styling change. Only affects addon suggestions, which are only shown when U.S. users type certain keywords.
• String changes made/needed:
• Is Android affected?: No

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/29d9ef63aed0

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9356747 [details]
Bug 1857114 - Update the icon in addon rows.

Approved for 119.0b7

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/ca30c902f724

Comment 9

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Issue is verified as fixed on Firefox 119.0b7(build ID: 20231009111645) and Nightly 120.0a1(build ID: 20231009212447) on macOS 12, Ubuntu 22, Windows 10.
Addon icon is now placed inside a gray box.