1857504 - Port bug 1855340: Avoid installer pinning popping a confirmation dialog on Windows 11 Insider Preview

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, task)

Description

[Richard Marti (:Paenglab)]

I can't test this but it's better to follow.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug 1857504 - Port bug 1855340: Avoid installer pinning popping a confirmation dialog on Windows 11 Insider Preview. r=rjl

This confirmation dialog is introduced on Windows version 22621.2361.
This commit disables the pinning in the installer on versions newer
than that. The onboarding process should do the pinning: in this
context, the confirmation dialog makes more sense.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/56dfe42bd94c
Port bug 1855340: Avoid installer pinning popping a confirmation dialog on Windows 11 Insider Preview. r=rjl

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 9357054 [details]
Bug 1857504 - Port bug 1855340: Avoid installer pinning popping a confirmation dialog on Windows 11 Insider Preview. r=rjl

[Approval Request Comment]
User impact if declined: on Windows 11 Dev preview additional confirmation dialog
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): should be low. I have no dev preview to test

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9357054 [details]
Bug 1857504 - Port bug 1855340: Avoid installer pinning popping a confirmation dialog on Windows 11 Insider Preview. r=rjl

[Triage Comment]
Approved for beta

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 119.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/49692e645c9e

Comment 6

[Richard Marti (:Paenglab)]

Attachment: 1857504-installer.patch

[Approval Request Comment]
User impact if declined: on Win11 DevPreview a confirmation dialog appears
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): should be okay when it is applied with bug 1858896

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9359502 [details] [diff] [review]
1857504-installer.patch

[Triage Comment]
Approved for esr115

Comment 8

[Daniel Darnell [:dandarnell]]

Thunderbird 115.4.0:
https://hg.mozilla.org/releases/comm-esr115/rev/e40ee923bdd1