1858006 - [win11] The installer no longer auto-pins in pre-22621.2361 builds of Windows.

Status: VERIFIED FIXED

(Firefox :: Shell Integration, defect, P2)

Description

[Michael Hughes]

+++ This bug was initially created as a clone of Bug #1855340 +++

Found in

• 118.2

Affected versions

• 118.2 and greater

Tested platforms

• Affected platforms: Windows 11x64
• Unaffected platforms: macOS 13, Ubuntu 22.1, Windows 10x64

Steps to reproduce

1. Complete the Firefox installation using the default installation pathway on Windows builds before the September 2023 release (Specifically, a 22621 build but with a lower UBR number than 2361)

Expected result

• Firefox is pinned without the user having to intervene

Actual result

• Firefox is not pinned

Regression range

• Not a regression

Additional notes

• Introduced by the fix for Bug #1855340

Comment 1

[Michael Hughes]

You can see what build of Windows you are on by going to the System Info (Press the Windows key, type System Info).
To figure out the UBR number, open up a PowerShell window in Admin mode and put this in:

(Get-ItemProperty -Path "HKLM:\SOFTWARE\Microsoft\Windows NT\CurrentVersion" -Name UBR).UBR

For me, it reports 2361. To verify this bug, you need a build of Windows that is 22621 for the build number, but lower than 2361 for the UBR number.

Comment 2

[Masatoshi Kimura [:emk]]

(In reply to Michael Hughes from comment #0)

• Introduced by the fix for Bug #1855340

Please use "… that is regressed by this bug" instead of "… as a clone of this bug".

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1855340

Comment 4

[Masatoshi Kimura [:emk]]

We already get the UBR number for Telemetry purpose.
https://searchfox.org/mozilla-central/rev/d265ec4f5fdcb5ad0c06636c5ac010ef4ff7eb89/browser/app/winlauncher/ErrorHandler.cpp#518
https://searchfox.org/mozilla-central/rev/d265ec4f5fdcb5ad0c06636c5ac010ef4ff7eb89/toolkit/modules/UpdateUtils.sys.mjs#1107
https://searchfox.org/mozilla-central/rev/d265ec4f5fdcb5ad0c06636c5ac010ef4ff7eb89/toolkit/mozapps/defaultagent/Telemetry.cpp#85

Comment 5

[Donal Meehan [:dmeehan]]

:max could this be triaged?

Comment 6

[Donal Meehan [:dmeehan]]

:mhughes we are in the final week of beta for Fx119, next week is RC week.
Is this being investigated and do we expect something for an uplift?

Comment 7

[Max Christian Pohle [:/dev/max]]

I have formally set the priority and severity to P2 and S3, but as you know by now this issue was already worked on when this bug was filed. This ticket will either require an assignee or should be marked as a duplicate and closed.

Comment 8

[Michael Hughes]

Attachment: Bug 1858006 - make installer auto-pin on Win 11 pre-UBR 2361 builds.

The previous commits to shared.nsh resulted in auto-pinning only occurring in Windows 11 builds that weren't build number 22621 or higher, but a lot of users on Windows 11 are on 22621 already and the build number to pay attention to, when MS introduced the user confirmation for pinning popup, is in Windows 11, 22621, UBR 2361.
This commit checks for the UBR number too.

Comment 9

[Michael Hughes]

(In reply to Donal Meehan [:dmeehan] from comment #6)

:mhughes we are in the final week of beta for Fx119, next week is RC week.
Is this being investigated and do we expect something for an uplift?

I would like to uplift this to Fx119 please.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6769216667ff
make installer auto-pin on Win 11 pre-UBR 2361 builds. r=nalexander

Comment 11

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

Comment on attachment 9358170 [details]
Bug 1858006 - make installer auto-pin on Win 11 pre-UBR 2361 builds.

Beta/Release Uplift Approval Request

• User impact if declined: New installs on Windows 11 10.0.22621 UBR < 2631 will not have the installer automatically pin. This is a partial reversion of the quick fix we landed in https://bugzilla.mozilla.org/show_bug.cgi?id=1855340.

A delay beyond Firefox Release 119 will impact pinning rates for longer than absolutely necessary.

• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Exactly the same as https://bugzilla.mozilla.org/show_bug.cgi?id=1855340#c9 but on Windows 10.0.22621 both <2631 and >=2631.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): An error here would cause a pinning popup, which is undesirable but not fatal.
• String changes made/needed:
• Is Android affected?: No

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/6769216667ff

Comment 13

[Donal Meehan [:dmeehan]]

Comment on attachment 9358170 [details]
Bug 1858006 - make installer auto-pin on Win 11 pre-UBR 2361 builds.

Approved for 119.0 RC1

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/fa08e9708cd5

Comment 15

[Hani Yacoub, Desktop QA]

Verified as fixed on Windows 11 x64 (version:22621 UBR number:2428) on Firefox Nightly 120.0a1 (2023-10-15).

Comment 16

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox 119.0 RC1 on Windows 11 x64.