1857835 - Message Convert to Event... no longer working - if mesage pane is turned off

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[karl]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/117.0.0.0 Safari/537.36

Steps to reproduce:

In the Messages pane right click on a message
Hover over Convert To
Move right and choose Event...

Actual results:

Nothing.

Expected results:

Event creation dialogue should open.

Name Thunderbird
Version 115.3.1
Build ID 20230928194049
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:115.0) Gecko/20100101 Thunderbird/115.3.1
OS Windows_NT 10.0 22621
Application Binary C:\Program Files (x86)\Mozilla Thunderbird\thunderbird.exe

Comment 1

[Magnus Melin [:mkmelin]]

Seems to work for me. Do you see a problem with Help | Troublshoot mode?

Comment 2

[karl]

(In reply to Magnus Melin [:mkmelin] from comment #1)

Seems to work for me. Do you see a problem with Help | Troublshoot mode?

Yes, still see the issue in Troubleshoot mode.

Comment 3

[sfhowes]

TB 115.2.3/W11, right-click a message in threads pane shows Convert to, but only if the message is open. In 102, Convert to appears in context menu for any message, so this is either a design change or regression. OP can also try right-clicking in message body or selecting from More button in header pane.

Comment 4

[karl]

To test this I opened a message. Then back in the threads pane I right-clicked and chose Convert To > Event... for the message I had open. The result is nothing. Nothing happens.

Could part of the problem be due to the fact that I haven't connected Thunderbird to the calendar of the email account I'm using? Currently, I only have my Google calendar connected. Historically, this setup has worked for me. I've never had the calendar of the email account linked (as it's hosted under cPanel, which doesn't allow for direct integration), but in the past, I've been able to right-click on an email and add it to my Google calendar.

Comment 5

[sfhowes]

If you have any calendar enabled on the Calendar tab, local or network, you should see the event dialog when Convert to|Event is selected from the context menu, of any opened message, from any account, not necessarily ones linked to a calendar. Correction to my first reply: Convert to shows in the context menu of a selected, unopened message if Message Pane is closed.

If menus aren't working when they should, test for a broken layout by running in safe/troubleshoot mode, and if that doesn't help, try in a new profile (Help/Troubleshooting, about:profiles), especially if your current one was created many versions ago.

Comment 6

[domy.gig]

I have noticed that, in my case, the "Convert to|Event" option works as expected only if I disable the official extension "Thunderbird Conversations". If I enable it, the functionality stops working as expected and the context menu option appears only in some specific cases (e.g: an email thread is opened and I select just one specific email)

Comment 7

[Magnus Melin [:mkmelin]]

Right, it's not working with Thunderbird Conversations (I don't know what you mean by official extension, there is no such thing). The authors are aware and there's another bug open to get that going.

Comment 8

[domy.gig]

Yeah, sorry, I confused two extensions I had installed. Anyway, can you link here the bug opened on Conversations?

Comment 9

[Magnus Melin [:mkmelin]]

Bug 1855843.

Comment 10

[karl]

I don't have the extension Thunderbird Conversations installed. Also when I run in Troubleshoot Mode the issue is still there.

Comment 11

[Quinda]

Check for Updates https://just-fall.com
Ensure that your software or application is up to date. Sometimes, issues like this can be resolved through software updates that address bugs and glitches.

Comment 12

[karl]

I have tried creating a new TB profile, marking it as default, closed and opened TB. On opening the new profile I still get exactly the same result; I opened a message. Then back in the threads pane I right-clicked and chose Convert To > Event... for the message I had open. The result is nothing. Nothing happens.

Comment 13

[Magnus Melin [:mkmelin]]

Is it only for a specific message? Anything in the Error Console?

Comment 14

[karl]

Applies to any message.
And yes there is an error console message:

Uncaught (in promise) TypeError: document.getElementById(...) is null
extractFromEmail chrome://calendar/content/calendar-extract.js:88
onMailContextMenuCommand chrome://messenger/content/mailContext.js:606
onCommand chrome://messenger/content/mailContext.js:149
handleEvent chrome://messenger/content/mailContext.js:131
2 calendar-extract.js:88:16

​<<after having tried twice.

Comment 15

[Magnus Melin [:mkmelin]]

https://searchfox.org/comm-central/rev/1c8566a212d10021faebd69f4a1ce3756d07f76c/calendar/base/content/calendar-extract.js#89 - but I don't know any circumstances where .getElementById("messageBrowser") is null and everything is fully loaded.

Comment 16

[Magnus Melin [:mkmelin]]

Oh, I see, you have the message pane turned off.

Comment 17

[Magnus Melin [:mkmelin]]

Attachment: Bug 1857835 - Make Message Convert to Event... work with message pane turned off. r=freaktechnik

Disabling it properly for .eml messages opened from file. The implementation won't work with that.

Also clearing out old cruft which is not used (outside the search dialog) post Supernova.

Comment 18

[karl]

OK I confirm that turning on the Message Pane works - in that when the Message Pane is turned on I can convert a message to an event or task but with it turned off convert to event or task does nothing.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b20d4e6585fa
Make Message Convert to Event... work with message pane turned off. r=freaktechnik

Comment 22

[Mark Banner (:standard8)]

Please can this be uplifted to ESR? The checks in AddToCalendarButton also break the functionality for the Conversations add-on.

Comment 23

[Magnus Melin [:mkmelin]]

Comment on attachment 9358955 [details]
Bug 1857835 - Make Message Convert to Event... work with message pane turned off. r=freaktechnik

[Approval Request Comment]
Regression caused by (bug #): supernova
User impact if declined: convert to event not working with message pane off (and with tb conversations)
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): should be ok with some beta baking

Comment 24

[Wayne Mery (:wsmwk)]

Comment on attachment 9358955 [details]
Bug 1857835 - Make Message Convert to Event... work with message pane turned off. r=freaktechnik

[Triage Comment]
Approved for beta

Comment 25

[Rob Lemley [:rjl]]

Thunderbird 120.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/35c01308bafe

Comment 26

[Wayne Mery (:wsmwk)]

Comment on attachment 9358955 [details]
Bug 1857835 - Make Message Convert to Event... work with message pane turned off. r=freaktechnik

[Triage Comment]
Approved for esr115

Comment 27

[Rob Lemley [:rjl]]

Thunderbird 115.4.2:
https://hg.mozilla.org/releases/comm-esr115/rev/b1291b00972b

Comment 28

[Rob Lemley [:rjl]]

Backout comm-esr115:
https://hg.mozilla.org/releases/comm-esr115/rev/80ec92ee8487

Comment 29

[Rob Lemley [:rjl]]

Thunderbird 115.4.2:
https://hg.mozilla.org/releases/comm-esr115/rev/d8272c5cc20b

Comment 30

[Rob Lemley [:rjl]]

Backout comm-esr115:
https://hg.mozilla.org/releases/comm-esr115/rev/27888f543a67e5041fb07a28a88331fe7f84c5b6
Reland comm-esr115:
https://hg.mozilla.org/releases/comm-esr115/rev/c114151b0b64f24b201a7642e493460f570885a2
Another backout:
https://hg.mozilla.org/releases/comm-esr115/rev/1074694a8791fd1a6747f31da6088a3a4a54bd46

Thunderbird 115.4.2:
https://hg.mozilla.org/releases/comm-esr115/rev/713f0c8db2933f87d523d36e25fa733bea6694b3