1858178 - RSS feeds with no favicon have a faint yellow globe icon

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Martin Giger [:freaktechnik]]

Attachment: image.png

RSS feeds without favicon get the default folder color for the default favicon instead of a more appropriate color.

Comment 1

[Martin Giger [:freaktechnik]]

Attachment: Bug 1858178 - Fix RSS feed default favicon color. r=#thunderbird-front-end-reviewers

Comment 2

[Kai Engert (:KaiE:)]

The patch doesn't apply cleanly. In your patch in the context, there's another RSS menuitem following, which isn't in the tree.

Can you please double check and supply an up-to-date patch?

Comment 3

[Martin Giger [:freaktechnik]]

Conflict with my own patch (Bug 1837152), fixed.

Comment 4

[Martin Giger [:freaktechnik]]

Pulling the checkin needed as I discovered another icon I think.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/98918b1e74bb
Fix RSS feed default favicon color. r=micahilbery

Comment 6

[Martin Giger [:freaktechnik]]

Attachment: bug1858178esr115.patch

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Default favicon is barely visible for RSS feeds
Testing completed (on c-c, etc.): Tested on c-c, local ESR build with the ESR patch.
Risk to taking this patch (and alternatives if risky): Low risk (CSS only)

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9361641 [details] [diff] [review]
bug1858178esr115.patch

[Triage Comment]
Approved for esr115

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 115.4.2:
https://hg.mozilla.org/releases/comm-esr115/rev/07117b37bf93