1859271 - Theme reverts to previous when opening the themes settings

Status: VERIFIED FIXED

(Thunderbird :: Add-Ons: General, defect)

Description

[Márton Gunyhó]

Attachment: Video showing theme being reverted when entering theme settings menu

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/118.0

Steps to reproduce:

1. Go to hamburger menu -> add-ons & themes -> themes
2. Click on "enable" for another theme than the current one (e.g. light when the current theme is dark)
3. Navigate away, and then back to the theme selection menu

Actual results:

The theme reverts to whatever theme was in use when the program launched, and all themes show "enable".

Expected results:

The selected theme should stay the same.

Comment 1

[John Bieling (:TbSync)]

Attachment: Bug 1859271 - Update STANDARD_THEMES to match version of built-in themes. r=#thunderbird-reviewers

This fixes a regression introduced by Bug 1844244. Since the version
number defined by STANDARD_THEMES no longer matched the actual version
number of the theme, they were installed again each time the theme
page was opened. This caused the enabled theme to flip.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/eacf4ccddedc
Update STANDARD_THEMES to match version of built-in themes. r=mkmelin

Comment 5

[Alexander Bergmann]

Can we uplift this patch, because Thunderbird 115.10.2 is still affected by the same problem as well?

Comment 6

[Wayne Mery (:wsmwk)]

(In reply to Alexander Bergmann from comment #5)

Can we uplift this patch, because Thunderbird 115.10.2 is still affected by the same problem as well?

John, I'm on board if you agree. (I actually came looking for this)

Comment 7

[John Bieling (:TbSync)]

Comment on attachment 9380113 [details]
Bug 1859271 - Update STANDARD_THEMES to match version of built-in themes. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): 1844244
User impact if declined: Theme switches back and forth
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): none

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9380113 [details]
Bug 1859271 - Update STANDARD_THEMES to match version of built-in themes. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 115.12.0:
https://hg.mozilla.org/releases/comm-esr115/rev/6be0efa873c1

Comment 10

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Confirming this issue as verified fixed for 115.12.1(20240618125055) with WIndows 11, Ubuntu 22 and macOS 14.