Modify desktop Suggest integration so it uses addon and Pocket suggestions from Rust
Categories
(Firefox :: Address Bar, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox120 | --- | fixed |
People
(Reporter: adw, Assigned: adw)
References
Details
Attachments
(1 file)
The latest vendoring of application-services into m-c (bug 1859069) picked up addon and Pocket suggestions from the suggest Rust component, but desktop hasn't yet been modified to query those two suggestion types.
|
Assignee | |
Comment 1•7 months ago
|
||
This builds on the recent vendor that was done in bug 1859069 and D191004 in
particular.
The parameter to the Rust SuggestStore.query() function now takes an object
with a providers property, instead of separate boolean sponsored and
nonsponsored properties. providers is an array whose items are integers that
identify Rust providers (defined in the RustSuggest bindings here).
MockRustSuggest in QuickSuggestTestUtils.sys.mjs is becoming kind of a pain
to keep updated. More tasks in test_quicksuggest_pocket.js should use Rust
than the ones I've updated here, but they don't because I would need to
(re)implement the prefix-matching behavior in MockRustSuggest. In a follow-up
I'd like to explore using a mock remote settings server instead so that the real
Rust component can be tested.
Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1b9473fe1ebe Modify desktop Suggest integration so it uses addon and Pocket suggestions from Rust. r=daisuke
|
||
Comment 3•7 months ago
|
||
Backed out for causing bc failures on browser_glean_telemetry_engagement_selected_result.js
Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0660f2279abf Modify desktop Suggest integration so it uses addon and Pocket suggestions from Rust. r=daisuke
|
|
Assignee | |
Updated•7 months ago
|
|
||
Comment 5•7 months ago
|
||
| bugherder | ||
Description
•