Closed Bug 1859442 Opened 2 years ago Closed 1 year ago

What Should I Work On Next: rename and enhancements

Categories

(bugzilla.mozilla.org :: General, enhancement)

Product:
bugzilla.mozilla.org
Component:
General
Version:
Production
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: glob, Assigned: dkl)

References

Details

Attachments

(2 files)

[mozilla-bteam/bmo] Bug 1859442 - What Should I Work On Next: rename and enhancements (#2162)
46 bytes, text/x-github-pull-request
Details | Review
Screenshot 2024-01-09 at 17-49-00 1 - dfasdfasd.png
9.46 KB, image/png
Details

Following feedback and discussion the following changes need to be made to the What Should I Work On Next dashboard:

  • Rename to "What Needs My Attention?"
    • Internal rename from whats_next to attention
    • The URL should be bugzilla.mozilla.org/attention
    • Redirect from the current URL
  • Change the icon to notification_important
  • Add a link to the documentation: https://firefox-source-docs.mozilla.org/bug-mgmt/policies/attention-dashboard.html
  • Add the following to the top of the page, below the auto-refresh toggle:
    • Code review requests are not visible on this dashboard; please visit Phabricator to view those. In general it’s reasonable and important to prioritize Review Requests to unblock others.
    • The word Phabricator should link to https://phabricator.services.mozilla.com/
  • Highest Priority Tasks section:
    • Change the subtitle to:
      • These are the things you should drop everything else for. Generally, work where you block others should be addressed as higher priority than non-blocking work.
    • Rename Important NEEDINFOs to Critical NEEDINFOs
    • Add needinfos on unrated security bugs to Critical NEEDINFOs (in addition to the existing bugs)
      • Bugs in a group ending with -security but do not have a keyword starting with sec-
    • Rename sec-critical bugs to Security-Critical Bugs
    • Change the order of the tables to:
      • Critical NEEDINFOs
      • S1 Bugs
      • Security-Critical Bugs
  • High Priority Tasks section:
    • Change the subtitle to:
      • High priority tasks are also "drop everything", except that in this case "everything" doesn't include anything in the "Highest priority" list. Generally, work where you block others should be addressed as higher priority than non-blocking work.
    • Rename Other NEEDINFOs to Important NEEDINFOs
    • Rename sec-high Bugs to Security-High Bugs
    • Remove the Regressions list
    • Add a new Other NEEDINFOs list:
      • NEEDINFOs that match all of the following conditions:
        • The requestee is the current user
        • The requester is not the current user
        • The bug's severity is not S1 or S2
        • The bug does not have a sec-critical or sec-high keyword
        • The bug is not in a group ending with -security
    • Change the order of the tables to:
      • Important NEEDINFOs
      • S2 Bugs
      • Security-High Bugs
      • Other NEEDINFOs

Hsin-Yi, does this look right?

Flags: needinfo?(htsai)

Updated comment 0 following discussions with Hsin-Yi. We should be good to go now.

Flags: needinfo?(htsai)

Yes, that is the great summary. Thank you for the help, glob!

Blocks: 1869838
Assignee: nobody → dkl
Status: NEW → ASSIGNED

(In reply to :glob ✱ from comment #0)

We might need to change the icon to something else as it looks very similar to the notifications icon next to it when a person has zero notifications. Or do not show the notifications icon at all if a user has zero notifications.

Flags: needinfo?(glob)

How about https://fonts.google.com/icons?selected=Material+Icons:engineering:

Flags: needinfo?(glob)

Status:
All of the tasks are complete and almost ready for review except for the two sections below which I should have done when I get back from public holiday on Tuesday.

(In reply to :glob ✱ from comment #0)

  • Rename Important NEEDINFOs to Critical NEEDINFOs
  • Add needinfos on unrated security bugs to Critical NEEDINFOs (in addition to the existing bugs)
    • Bugs in a group ending with -security but do not have a keyword starting with sec-
  • Add a new Other NEEDINFOs list:
    • NEEDINFOs that match all of the following conditions:
      • The requestee is the current user
      • The requester is not the current user
      • The bug's severity is not S1 or S2
      • The bug does not have a sec-critical or sec-high keyword
      • The bug is not in a group ending with -security

(In reply to :glob ✱ from comment #6)

How about https://fonts.google.com/icons?selected=Material+Icons:engineering:

Works for me. We can change it later of course if we see something better.

Note for self from Slac
I found a bug in the attention dashboard's js; since you're touching it probably easier for you to fix it.

-  const count = Number(document.querySelector("#total-bug-count").textContent);
+  let count = Number(document.querySelector("#total-bug-count").textContent);
   if (count == 0) return;

The bug is if someone has more a count which won't fix in the favicon, it should show xx, but as count is a const the assignment fails.
https://bugzilla.mozilla.org/page.cgi?id=whats_next.html&action=run&who=dao%2Bbmo%40mozilla.com as an example

Also, for dao the count at the top of the table is wrong. It says "323 bugs", however the bug list only returns 317. document.querySelector("#total-bug-count").textContent reports 318 (the correct value as there's 317 needinfos and 1 regression)

There's multiple needinfos on the same bugs. eg https://bugzilla.mozilla.org/show_bug.cgi?id=1756320.
The header should say "323 requests" rather than "bugs"

(In reply to David Lawrence [:dkl] from comment #9)

Note for self from Slac
I found a bug in the attention dashboard's js; since you're touching it probably easier for you to fix it.

-  const count = Number(document.querySelector("#total-bug-count").textContent);
+  let count = Number(document.querySelector("#total-bug-count").textContent);
   if (count == 0) return;

The bug is if someone has more a count which won't fix in the favicon, it should show xx, but as count is a const the assignment fails.
https://bugzilla.mozilla.org/page.cgi?id=whats_next.html&action=run&who=dao%2Bbmo%40mozilla.com as an example

Fixed

Also, for dao the count at the top of the table is wrong. It says "323 bugs", however the bug list only returns 317. document.querySelector("#total-bug-count").textContent reports 318 (the correct value as there's 317 needinfos and 1 regression)

There's multiple needinfos on the same bugs. eg https://bugzilla.mozilla.org/show_bug.cgi?id=1756320.
The header should say "323 requests" rather than "bugs"

Adding a DISTINCT to the queries should fix this. Pushing to bugzilla-dev now.

(In reply to David Lawrence [:dkl] from comment #10)

There's multiple needinfos on the same bugs. eg https://bugzilla.mozilla.org/show_bug.cgi?id=1756320.
The header should say "323 requests" rather than "bugs"

Adding a DISTINCT to the queries should fix this. Pushing to bugzilla-dev now.

So this did not seem to fix the duplicate row issue seen when using dao+bmo@mozilla.com so I am going to keep poking at that.

hsin-yi, do you mind taking a look at what is currently done and make sure that it fits with what you were requesting? I have installed the latest changes on https://bugzilla-dev.allizom.org/page.cgi?id=attention.html for your feedback.

Thanks

Flags: needinfo?(htsai)

(In reply to David Lawrence [:dkl] from comment #11)

(In reply to David Lawrence [:dkl] from comment #10)

There's multiple needinfos on the same bugs. eg https://bugzilla.mozilla.org/show_bug.cgi?id=1756320.
The header should say "323 requests" rather than "bugs"

Adding a DISTINCT to the queries should fix this. Pushing to bugzilla-dev now.

So this did not seem to fix the duplicate row issue seen when using dao+bmo@mozilla.com so I am going to keep poking at that.

Nevermind. The deployment process did not push my latest changes and need to be re-ran. Now the DISTINCT fix seems to have fixed the duplicate rows issue.

(In reply to David Lawrence [:dkl] from comment #11)

(In reply to David Lawrence [:dkl] from comment #10)

There's multiple needinfos on the same bugs. eg https://bugzilla.mozilla.org/show_bug.cgi?id=1756320.
The header should say "323 requests" rather than "bugs"

Adding a DISTINCT to the queries should fix this. Pushing to bugzilla-dev now.

So this did not seem to fix the duplicate row issue seen when using dao+bmo@mozilla.com so I am going to keep poking at that.

The multiple rows are correct, it's only the header that needs changing.

The query is returning flags, so if someone has multiple needinfo flags set on the same bug, there'll be multiple rows pointing at the same bug. That's correct because each needinfo flag (ie. each row in the table) has different metadata.

All that needs to change is the header for all needinfo lists; from the word "bugs" to "requests".

(In reply to David Lawrence [:dkl] from comment #11)

(In reply to David Lawrence [:dkl] from comment #10)

There's multiple needinfos on the same bugs. eg https://bugzilla.mozilla.org/show_bug.cgi?id=1756320.
The header should say "323 requests" rather than "bugs"

Adding a DISTINCT to the queries should fix this. Pushing to bugzilla-dev now.

So this did not seem to fix the duplicate row issue seen when using dao+bmo@mozilla.com so I am going to keep poking at that.

hsin-yi, do you mind taking a look at what is currently done and make sure that it fits with what you were requesting? I have installed the latest changes on https://bugzilla-dev.allizom.org/page.cgi?id=attention.html for your feedback.

Thanks

Hi David, thank you very much for the support. I think this item - important NEEDINFOs - requires more tweaks .

High Priority Tasks section:
Rename Other NEEDINFOs to Important NEEDINFOs

It's more than "rename"; actually the criterion change as well. The new important NEEDINFOs include only bugs that are needinfo? you and are marked as Severity = S2 defects or with the “sec-high” keyword. I apologize that I didn't catch this or explain clearly enough when I reviewed the requirements in comment 0.

And I also found an issue in this item

Highest Priority Tasks section:
Add needinfos on unrated security bugs to Critical NEEDINFOs (in addition to the existing bugs)

For example, I expect 'Bug 1875248' in the Critical NEEDINFOs list of :nika; however, bug 1875248 isn't there in attention dashboard at all. Another example is the unrated security bug 1875630 for :edgar.

For the S2 bug or sec-high bug list, there seems to be something wrong as well. For example , I got empty lists for :kagami in the current attention dashboard, while 'whats_next.html' gave me several bugs.

Thank you for the support again. :) Hope my comment helps.

Flags: needinfo?(htsai)

(In reply to Hsin-Yi Tsai (she/her) [:hsinyi] from comment #14)

For example, I expect 'Bug 1875248' in the Critical NEEDINFOs list of :nika; however, bug 1875248 isn't there in attention dashboard at all. Another example is the unrated security bug 1875630 for :edgar.

Neither of those bugs exist on the bugzilla-dev.mozilla.org instance (it's a snapshot from Sep 2023).

(In reply to :glob ✱ from comment #15)

(In reply to Hsin-Yi Tsai (she/her) [:hsinyi] from comment #14)

For example, I expect 'Bug 1875248' in the Critical NEEDINFOs list of :nika; however, bug 1875248 isn't there in attention dashboard at all. Another example is the unrated security bug 1875630 for :edgar.

Neither of those bugs exist on the bugzilla-dev.mozilla.org instance (it's a snapshot from Sep 2023).
I see! Thanks for the clarity.

(In reply to Hsin-Yi Tsai (she/her) [:hsinyi] from comment #14)

Hi David, thank you very much for the support. I think this item - important NEEDINFOs - requires more tweaks .

High Priority Tasks section:
Rename Other NEEDINFOs to Important NEEDINFOs

It's more than "rename"; actually the criterion change as well. The new important NEEDINFOs include only bugs that are needinfo? you and are marked as Severity = S2 defects or with the “sec-high” keyword. I apologize that I didn't catch this or explain clearly enough when I reviewed the requirements in comment 0.

(In reply to :glob ✱ from comment #13)

All that needs to change is the header for all needinfo lists; from the word "bugs" to "requests".

I have made the requested changes and pushed the latest version to https://bugzilla-dev.allizom.org/page.cgi?id=attention.html for your feedback. Please let me know what you think.

Flags: needinfo?(htsai)

I shared the testing results and have been in conversations with :dkl on slack.

Flags: needinfo?(htsai)

Hi David, is there any update and can you please provide ETA here? Thank you.

Flags: needinfo?(dkl)

(In reply to Hsin-Yi Tsai (she/her) [:hsinyi] from comment #19)

Hi David, is there any update and can you please provide ETA here? Thank you.

I have worked on this one and off over the last couple weeks between fighting spammers and some personal medical related stuff. I have latest changes pushed now to https://bugzilla-dev.allizom.org which I hope has improved on some the problems you were having. Please check it out and let me know.

dkl

Flags: needinfo?(dkl) → needinfo?(htsai)

(In reply to David Lawrence [:dkl] from comment #20)

(In reply to Hsin-Yi Tsai (she/her) [:hsinyi] from comment #19)

Hi David, is there any update and can you please provide ETA here? Thank you.

I have worked on this one and off over the last couple weeks between fighting spammers and some personal medical related stuff. I have latest changes pushed now to https://bugzilla-dev.allizom.org which I hope has improved on some the problems you were having. Please check it out and let me know.

dkl

Thanks for the update!
Now I see that closed bugs with needinfos are included. Other than that, most of the issues I reported here, the items with a red-cross mark, still seem unresolved.

Flags: needinfo?(htsai)

(In reply to Hsin-Yi Tsai (she/her) [:hsinyi] from comment #21)

Thanks for the update!
Now I see that closed bugs with needinfos are included. Other than that, most of the issues I reported here, the items with a red-cross mark, still seem unresolved.

Hmm. I was able to successfully test each of the cases locally but something still seems to be wrong on bugzilla-dev and giving bad results. I will continue to look at this today so we can get this wrapped up and pushed live.

Thanks

(In reply to Hsin-Yi Tsai (she/her) [:hsinyi] from comment #21)

(In reply to David Lawrence [:dkl] from comment #20)

(In reply to Hsin-Yi Tsai (she/her) [:hsinyi] from comment #19)

Hi David, is there any update and can you please provide ETA here? Thank you.

I have worked on this one and off over the last couple weeks between fighting spammers and some personal medical related stuff. I have latest changes pushed now to https://bugzilla-dev.allizom.org which I hope has improved on some the problems you were having. Please check it out and let me know.

dkl

Thanks for the update!
Now I see that closed bugs with needinfos are included. Other than that, most of the issues I reported here, the items with a red-cross mark, still seem unresolved.

I have added notes to https://docs.google.com/document/d/1hLEgx4jVbFzOJ479-Fa9h_Hq5WzEwdfrZcHUUh-5Uwg/edit with explanation for some of the broken results. Please take a look and reverify. Thanks!

Flags: needinfo?(htsai)

(In reply to David Lawrence [:dkl] from comment #23)

(In reply to Hsin-Yi Tsai (she/her) [:hsinyi] from comment #21)

(In reply to David Lawrence [:dkl] from comment #20)

(In reply to Hsin-Yi Tsai (she/her) [:hsinyi] from comment #19)

Hi David, is there any update and can you please provide ETA here? Thank you.

I have worked on this one and off over the last couple weeks between fighting spammers and some personal medical related stuff. I have latest changes pushed now to https://bugzilla-dev.allizom.org which I hope has improved on some the problems you were having. Please check it out and let me know.

dkl

Thanks for the update!
Now I see that closed bugs with needinfos are included. Other than that, most of the issues I reported here, the items with a red-cross mark, still seem unresolved.

I have added notes to https://docs.google.com/document/d/1hLEgx4jVbFzOJ479-Fa9h_Hq5WzEwdfrZcHUUh-5Uwg/edit with explanation for some of the broken results. Please take a look and reverify. Thanks!

Hey David, thanks for the additional notes. :) I finished another round of testing. Please find my comments, in purple color, again in the doc. Several issues were verified; some were partially fixed.

Flags: needinfo?(htsai)

(In reply to Hsin-Yi Tsai (she/her) [:hsinyi] from comment #24)

Hey David, thanks for the additional notes. :) I finished another round of testing. Please find my comments, in purple color, again in the doc. Several issues were verified; some were partially fixed.

Thank you for your continued patience and your review comments. I will take a look at them this morning. Hopefully we are getting closer to completion.

(In reply to David Lawrence [:dkl] from comment #25)

(In reply to Hsin-Yi Tsai (she/her) [:hsinyi] from comment #24)

Hey David, thanks for the additional notes. :) I finished another round of testing. Please find my comments, in purple color, again in the doc. Several issues were verified; some were partially fixed.

Thank you for your continued patience and your review comments. I will take a look at them this morning. Hopefully we are getting closer to completion.

I have added some comments to the google document for discussion. Seems like if I just remove the duplicates across all lists instead of just de-duplication per list (which I am doing now) we should be close to being done.

Flags: needinfo?(htsai)

I believed we are on the same page of the remaining blocking issues as well as nice-to-have follow-ups after the first roll out. Please feel free to NI again, for another round of testing. We're so close to be done. :)

Flags: needinfo?(htsai)

(In reply to Hsin-Yi Tsai (she/her) [:hsinyi] from comment #27)

I believed we are on the same page of the remaining blocking issues as well as nice-to-have follow-ups after the first roll out. Please feel free to NI again, for another round of testing. We're so close to be done. :)

Ok latest change with changes all requests to be require not being self-needinfo is now on bugzilla-dev.allizom.org if you want to try it out.

Merged
https://github.com/mozilla-bteam/bmo/commit/5677283fa1f207a98a9b321ab8748001d46d1875

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED

Hi David, when can users see the changes in the production instance? Thanks again for your support!

Flags: needinfo?(dkl)

(In reply to Hsin-Yi Tsai (she/her) [:hsinyi] from comment #30)

Hi David, when can users see the changes in the production instance? Thanks again for your support!

I was going to wait til first of next week but decided to go ahead and push to prod now. So you should be good now.

Flags: needinfo?(dkl)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: