1859512 - [flatpak] Prepare CI for publishing to Flathub changes scheduled for November 6th 2023.

Status: RESOLVED FIXED

(Thunderbird :: Build Config, task)

Description

[Bartłomiej Piotrowski]

+++ This bug was initially created as a clone of Bug #1859510 +++

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/118.0

Steps to reproduce:

There are upcoming Flathub changes that will lock Thunderbird updates from being properly published.

flat-manager-client create needs to specify --build-log-url $URL, where $URL points to the build log of runme.sh. The Docker image used for flat-manager-client will be updated shortly, but the latest version can be also fetched with wget/curl from https://raw.githubusercontent.com/flatpak/flat-manager/master/flat-manager-client.

Comment 1

[Bartłomiej Piotrowski]

The rollout of that change is scheduled in about 3 weeks, on November 6th 2023. I can push it by a week if it helps.

The server-side validation can be replicated as part of your CI by using flatpak-builder-lint tool on the repo archive created by runme.sh. The tool is available in the ghcr.io/flathub/flatpak-builder-lint:latest Docker image, and an example usage looks like this:

flatpak-builder-lint repo /path/to/repo

Comment 2

[Bartłomiej Piotrowski]

Alternatively,

flatpak-builder-lint --exceptions repo /path/to/repo

To better emulate what Flathub will be doing. If there are no errors reported (also indicated by exit status code), it will pass the validation on Flathub's side as well.

Comment 3

[Rob Lemley [:rjl]]

Quickly looking at this, flat-manager-client create is run in the pushflatpak scriptworker. As that infrastructure is shared between Firefox and Thunderbird, there's nothing to do there.

The flatpak-builder-lint piece sounds like it would need to run as an intermediary job between release-flatpak-repackage and the push job run by the scriptworker.

Again, since Firefox has to do this as well I'll sort of defer to see how they handle it.

Comment 4

[Emerson Bernier]

Firefox ticket was closed with the https://github.com/mozilla-releng/scriptworker-scripts/pull/861

Comment 5

[Rob Lemley [:rjl]]

Bug 1867428 needs to be fixed, but when it is this bug can close along along with it.