1867428 - release-push-flatpak tries to use wrong scopes

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect, P1)

Description

[Rob Lemley [:rjl]]

Client ID task-client/f-TYANruT36dl5ZJW7jgcg/0/on/us-central1/6121813105720314584/until/1701312830.229 does not have sufficient scopes and is missing the following scopes:

project:comm:thunderbird:releng:flathub:firefox:beta

This request requires the client to satisfy the following scope expression:

{
  "AllOf": [
    "project:comm:thunderbird:releng:flathub:firefox:beta",
    "queue:route:tc-treeherder.v2.comm-beta.00853cf0251b46900dadfb74af4c7c38b5484dc7",
    "queue:create-task:project:none",
    "queue:scheduler-id:comm-level-3",
    {
      "AnyOf": [
        "queue:create-task:highest:scriptworker-k8s/comm-3-pushflatpak",
        "queue:create-task:very-high:scriptworker-k8s/comm-3-pushflatpak",
        "queue:create-task:high:scriptworker-k8s/comm-3-pushflatpak"
      ]
    }
  ]
}

That scope is being incorrectly assigned by gecko_taskgraph code, so the server is correctly rejecting the request.

The scope will need to be adjusted for Thunderbird.

Comment 1

[Daniel Darnell [:dandarnell]]

Attachment: Bug 1867428 - Set Flathub scope in release-push-flatpak via description schema to allow for different scopes. r=jcristau

Comment 2

[Daniel Darnell [:dandarnell]]

Attachment: Bug 1867428 - Set Flathub scope in release-flatpak-push kind.yml. r=#thunderbird-build-system-reviewers

Comment 3

[Daniel Darnell [:dandarnell]]

Comment on attachment 9366433 [details]
Bug 1867428 - Set Flathub scope in release-push-flatpak via description schema to allow for different scopes. r=jcristau

Beta/Release Uplift Approval Request

• User impact if declined: This should not affect Firefox users at all, as there is no change to Firefox's Flatpak push task configuration. This patch just allows for alternate scopes in release-push-flatpak. Without this change, Thunderbird will not be able to use release-push-flatpak, preventing the Thunderbird Flatpak from being pushed to Flathub.
• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch is very low risk, as it does not modify Firefox's task settings.
• String changes made/needed:
• Is Android affected?: No

Comment 4

[Daniel Darnell [:dandarnell]]

Comment on attachment 9366434 [details]
Bug 1867428 - Set Flathub scope in release-flatpak-push kind.yml. r=#thunderbird-build-system-reviewers

[Approval Request Comment]
User impact if declined: Flatpak pushing will not happen automatically (no tangible difference to the end user, but this change is needed to finish the Flatpak release process)
Testing completed (on c-c, etc.): N/A (this change cannot be fully tested without running it on an actual release)
Risk to taking this patch (and alternatives if risky): Low

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ca5f3533d97
Set Flathub scope in release-push-flatpak via description schema to allow for different scopes. r=jcristau,taskgraph-reviewers,releng-reviewers,rjl

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out for causing failures on test_generate_params.py.

Push with failure: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=4ca5f3533d97f80552d7c1f2c13cbace21101e3a&selectedTaskRun=XYzyKabaSy6Wu8VGccQPoQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=438917330&repo=autoland

backout link: https://hg.mozilla.org/integration/autoland/rev/23ee4ac2d048de0aac3fa27ce7eb0925c1903096

Comment 7

[Daniel Darnell [:dandarnell]]

(In reply to Cosmin Sabou [:CosminS] from comment #6)

Backed out for causing failures on test_generate_params.py.

Push with failure: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=4ca5f3533d97f80552d7c1f2c13cbace21101e3a&selectedTaskRun=XYzyKabaSy6Wu8VGccQPoQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=438917330&repo=autoland

backout link: https://hg.mozilla.org/integration/autoland/rev/23ee4ac2d048de0aac3fa27ce7eb0925c1903096

I've updated the patch and tested the previously failing task on try here: https://treeherder.mozilla.org/jobs?repo=try&revision=21a5da7d5d00d75154a2d8a950cf5066eeb148aa

The task is now succeeding and should be good to go.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/408535dafc82
Set Flathub scope in release-push-flatpak via description schema to allow for different scopes. r=jcristau,taskgraph-reviewers,releng-reviewers,rjl

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9366434 [details]
Bug 1867428 - Set Flathub scope in release-flatpak-push kind.yml. r=#thunderbird-build-system-reviewers

[Triage Comment]
Approved for beta

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/408535dafc82

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/8ecfa2e50984

Comment 12

[Julien Cristau [:jcristau]]

Attachment: Bug 1867428 - fix release-flathub-push task generation on staging. r?#releng

We were using and removing flathub-scope from the job for production
releases, but on staging/try it was staying around causing a schema
validation error later on.

Comment 13

[Phabricator Automation]

Comment on attachment 9367229 [details]
Bug 1867428 - fix release-flathub-push task generation on staging. r?#releng

Revision D195634 was moved to bug 1868547. Setting attachment 9367229 [details] to obsolete.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9366433 [details]
Bug 1867428 - Set Flathub scope in release-push-flatpak via description schema to allow for different scopes. r=jcristau

Looks like this already got pushed a=release

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0b49a898dc58
Set Flathub scope in release-flatpak-push kind.yml. r=rjl DONTBUILD

Comment 16

[Rob Lemley [:rjl]]

Thunderbird 121.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/bc7557433d5d

Comment 17

[Rob Lemley [:rjl]]

Attachment: comm-esr115.patch

[Triage Comment]
This is a version of the comm-central patch for comm-esr115 that uses its own copy of release_flatpak_push.py (from mozilla-beta).

This allows Thunderbird to ship Flatpaks from esr115 without needing to uplift the gecko_taskgraph changes to mozilla-esr115.

The code in question has been successfully run on comm-beta.

Comment 18

[Rob Lemley [:rjl]]

Thunderbird 115.5.2:
https://hg.mozilla.org/releases/comm-esr115/rev/c3115839b045