1859581 - [HCM] The visibility of the text within the banners and the "X" button is reduced with the new private theme

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect, P1)

Description

[Simona Badau, Desktop QA]

Attachment: The new private tab in HCM

Found in

• Nightly 120.0a1

Affected versions

• Nightly 120.0a1

Tested platforms

• Affected platforms: Ubuntu 22.04, macOS 11.7, Windows 10.

Preconditions

• In about:config, set "browser.privatebrowsing.felt-privacy-v1" to true
• Enable High Contrast Mode.

Steps to reproduce

1. Open a private window.
2. Observe the visibility of text in the banners and the "X" button.

Expected result

• The text within the banners and the "X" button should be easily visible in High Contrast Mode.

Actual result

• With the new private theme, the text within the banners and the "X" control button is difficult to read due to insufficient contrast.

Regression range

• Not a regression.

Comment 1

[Anna Yeddi [:ayeddi]]

Thank you for filing the bug, Simona!

The color contrast of the text within both banners is 1.5:1 while it is expected that the color contrast would be at least 4.5:1 for WCAG 2.2 Level AA compliance (Success Criterion 1.4.3 Contrast (Minimum)) and at least 7:1 for WCAG 2.2 Level AAA compliance (Success Criterion 1.4.6 Contrast (Enhanced)) and for High Contrast Mode support.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:timhuang, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 3

[:cmkm]

I can reproduce this only on Ubuntu's high contrast mode. The text color from common-shared.css, --in-content-page-color, resolves to black on Ubuntu and white on macOS.

Comment 4

[:cmkm]

Attachment: Bug 1859581 - PBM contrast colors should remain unchanged r?dwalker,mhowell

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8df76f3d891
PBM contrast colors should remain unchanged r=dwalker,desktop-theme-reviewers,dao

Comment 6

[:cmkm]

Attachment: Beta uplift request

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1847102
[User impact if declined]: Text contrast issue for Ubuntu users in Felt Privacy v1 experiment
[Is this code covered by automated tests?]: No, styling only
[Has the fix been verified in Nightly?]: Not yet - due to US/CA holiday weekend, requesting uplift per discussion with :diannaS
[Needs manual test from QE? If yes, steps to reproduce]: Yes, steps:

1. In Ubuntu, toggle high contrast accessibility setting
2. Set browser.privatebrowsing.felt-privacy-v1 to true
3. Open a new private browsing window and verify that text contrast is sufficient

[Why is the change risky/not risky?]: Not risky, styling only
[String changes made/needed]: n/a

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/d8df76f3d891

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9362926 [details]
Beta uplift request

Approved for out last beta, thanks.

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/73b74ae56a97

Comment 10

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/73b74ae56a97

Comment 11

[Simona Badau, Desktop QA]

Verified as fixed using Firefox 120.0b9 and the latest Nightly 121.0a1 (Build ID: 20231113091505) on Ubuntu 22.04, macOS 11.7 and Windows 10.

While verifying this issue, I observed that on Windows 10, the generic search icon in the web search field is not visible when a high-contrast black theme is enabled (logged Bug 1864478 to cover this issue). Additionally, I noticed that the Firefox logo for private browsing is missing. Cieara, could you please confirm whether the absence of the logo is intended for Windows 10?

Comment 12

[:cmkm]

(In reply to Simona Badau, Desktop QA from comment #11)

Cieara, could you please confirm whether the absence of the logo is intended for Windows 10?

It isn't intentional, I suspect the wordmark SVG isn't adapting to the high contrast themes. UX is currently going through the accessibility review process for HCM on this page, we can address this as soon as possible alongside those other changes.

Comment 13

[Simona Badau, Desktop QA]

(In reply to Cieara Meador [:cmkm] from comment #12)

It isn't intentional, I suspect the wordmark SVG isn't adapting to the high contrast themes. UX is currently going through the accessibility review process for HCM on this page, we can address this as soon as possible alongside those other changes.

I logged Bug 1864876 to cover this issue as well.