1861618 - shared-libraries-linux.cc: do not use 'else' after 'return'

Status: RESOLVED FIXED

(Core :: mozglue, task)

Description

[Sylvestre Ledru [:Sylvestre]]

+++ This bug was initially created as a clone of Bug #1860247 +++

+++ This bug was initially created as a clone of Bug #1857751 +++

Filling as a good first bug to learn workflows.

do not use 'else' after 'return':
https://searchfox.org/mozilla-central/source/mozglue/baseprofiler/core/shared-libraries-linux.cc#520-522

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[Tawah Peggy]

Attachment: Bug 1861618 - Do not use 'else' after 'return'. r?Sylvestre

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb450a287979
Do not use 'else' after 'return'. r=sylvestre,profiler-reviewers,canaltinova

Comment 3

[Cristian Tuns]

Backed out for causing build bustages in ClearKeyUtils.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/media/gmp-clearkey/0.1/ClearKeyUtils.cpp:251:12: error: unused variable 'idx' [-Werror,-Wunused-variable]

+Bc failures: https://treeherder.mozilla.org/logviewer?job_id=434630102&repo=autoland

Comment 4

[Tawah Peggy]

Attachment: Bug 1861618 - Reduce usage of return statements after else. r?Sylvestre

Comment 5

[Tawah Peggy]

I have submitted a new patch without the error, please check it out.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8d3ee0a4942
Reduce usage of return statements after else. r=sylvestre DONTBUILD

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d8d3ee0a4942