shared-libraries-linux.cc: do not use 'else' after 'return'
Categories
(Core :: mozglue, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox121 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: tawahpeggy98, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(2 files)
+++ This bug was initially created as a clone of Bug #1860247 +++
+++ This bug was initially created as a clone of Bug #1857751 +++
Filling as a good first bug to learn workflows.
do not use 'else' after 'return':
https://searchfox.org/mozilla-central/source/mozglue/baseprofiler/core/shared-libraries-linux.cc#520-522
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
|
Assignee | |
Comment 1•6 months ago
|
||
|
||
Updated•6 months ago
|
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fb450a287979 Do not use 'else' after 'return'. r=sylvestre,profiler-reviewers,canaltinova
|
||
Comment 3•6 months ago
•
|
||
Backed out for causing build bustages in ClearKeyUtils.cpp
- Backout link
- Push with failures
- Failure Log
- Failure line: /builds/worker/checkouts/gecko/media/gmp-clearkey/0.1/ClearKeyUtils.cpp:251:12: error: unused variable 'idx' [-Werror,-Wunused-variable]
+Bc failures: https://treeherder.mozilla.org/logviewer?job_id=434630102&repo=autoland
|
|
Assignee | |
Comment 4•6 months ago
|
||
|
|
Assignee | |
Comment 5•6 months ago
|
||
I have submitted a new patch without the error, please check it out.
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d8d3ee0a4942 Reduce usage of return statements after else. r=sylvestre DONTBUILD
|
|
||
Comment 7•6 months ago
|
||
| bugherder | ||
Description
•