1861669 - Bookmarks sidebar: bookmark folder name disappears when the folder is collapsed

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[toifl]

Attachment: after_closing_folder.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/119.0

Steps to reproduce:

I use macOS 12.7 on the iMac (late 2015). After the Firefox update to version 119.0 (64 bit) I noticed the following bug: If I open a link from a bookmarks folder in the sidebar and then close the folder, the folder name is no longer displayed in the sidebar. The bug doesn't occur in private mode!

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Mark Banner (:standard8)]

Confirming, I can reproduce this with the steps mentioned in comment 0. I'm on Mac Ventural 13.6.

Comment 4

[Mark Banner (:standard8)]

[Tracking Requested - why for this release]: Apparent regression in 119 release, only affects sidebar users as far as I know.

Comment 5

[Mark Banner (:standard8)]

Mozregression says this is from bug 1843044.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1843044

:emilio, since you are the author of the regressor, bug 1843044, could you take a look?

For more information, please visit BugBot documentation.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1861669 - Approach 1: Make vibrancy work again on OSX. r=dao,#theme

macOS needs a transparent root background in order for vibrancy to work
(showing the contents behind the window). Bug 1843044 broke this.

Long ago, we used to do vibrancy more aggressively (on the titlebar
etc), but now the sidebar is the only thing that has that left.

This fixes it, but it's a bit action-at-a-distance.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1861669 - Approach 2: Remove vibrancy on the osx sidebar. r=#theme,#mac-reviewers!

(Can prepare a more minimal upliftable patch)

This accidentally broke in 119 and nobody noticed on the whole nightly +
beta cycle (other than due to this bug).

Given sidebars are not super-commonly used these days, this makes the
code a bit less fragile, and it still looks pretty good IMO. Also, since
we want to get rid of <xul:tree>s, this is one less thing to bother
about.

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9360680 [details]
Bug 1861669 - Approach 1: Make vibrancy work again on OSX. r=dao,#theme

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One liner css fix
• String changes made/needed: none
• Is Android affected?: No

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d069534e39df
Approach 1: Make vibrancy work again on OSX. r=dao,desktop-theme-reviewers

Comment 12

[Phabricator Automation]

Comment on attachment 9360681 [details]
Bug 1861669 - Approach 2: Remove vibrancy on the osx sidebar. r=#theme,#mac-reviewers!

Revision D192103 was moved to bug 1861954. Setting attachment 9360681 [details] to obsolete.

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox119 (release). However, the bug still has low severity.

:cbellini, could you please increase the severity for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 14

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d069534e39df

Comment 16

[Dianna Smith [:diannaS]]

Comment on attachment 9360680 [details]
Bug 1861669 - Approach 1: Make vibrancy work again on OSX. r=dao,#theme

Approved for 120.0b5

Comment 17

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/21c4c089d274

Comment 18

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox 121.0a1 (2023-10-31) on macOS 11.6.

Comment 20

[Donal Meehan [:dmeehan]]

:emilio could you consider adding a release uplift request?
This is tracked for Fx119 and picking up duplicates.

Comment 21

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox 120.0b5 on macOS 11.6.

Comment 22

[Emilio Cobos Álvarez (:emilio)]

Attachment: Release patch

Approval Request Comment
[Feature/Bug causing the regression]: See above
[User impact if declined]: See above
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: yes, comment 0
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: one-liner
[String changes made/needed]: none

Comment 23

[Donal Meehan [:dmeehan]]

:emilio that release patch fails linter checks

15:3 error Unexpected duplicate "background-color" declaration-block-no-duplicate-properties (stylelint)

Comment 24

[Emilio Cobos Álvarez (:emilio)]

No it doesn't (when applied to the release branch)? What am I missing? Did you apply the patch twice or something by any chance?

https://searchfox.org/mozilla-release/rev/fadabf3241591ce49edaf3c1f5cbb87f3a088b29/browser/themes/osx/browser.css#10 doesn't have any background-color declaration.

Comment 25

[Donal Meehan [:dmeehan]]

Odd, not sure why it was failing before. Tried again and it's passing.
Sorry for the noise. Will accept and push this uplift request.

Comment 26

[Donal Meehan [:dmeehan]]

Comment on attachment 9361462 [details] [diff] [review]
Release patch

Approved for 119.0.1

Comment 27

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/49e265b9b3bd

Comment 28

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox 119.0.1 on macOS 11.6.