Consider removing vibrancy in the macOS sidebar.
Categories
(Firefox :: Theme, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox121 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(3 files)
With vibrancy
See bug 1861669 and relevant commit message...
This broke in 119 and nobody noticed except for that bug. I think given sidebars are not super-used nowadays, and that we want to remove the XUL tree specialness, we should consider removing it.
I'll attach screenshots in a bit. Jules, can you confirm that this is fine from a UX perspective?
|
Assignee | |
Comment 1•8 months ago
|
||
|
|
Assignee | |
Comment 2•8 months ago
|
||
|
|
Assignee | |
Comment 3•8 months ago
|
||
I used dark windows below to increase the effect. But I think "no vibrancy" still looks pretty good, and given comment 0 and the reasons described in the patch, I think it's probably nicer.
|
|
Assignee | |
Comment 4•8 months ago
|
||
This accidentally broke in 119 and nobody noticed on the whole nightly +
beta cycle (other than due to bug 1861669).
Given sidebars are not super-commonly used these days, this makes the
code a bit less fragile, and it still looks pretty good IMO. Also, since
we want to get rid of <xul:tree>s, this is one less thing to worry
about.
Depends on D192102
|
||
Comment 5•8 months ago
|
||
Looks good to me. Seems like it used to be an effect to try to mock the whole transparency blur effect on macOS, right?
We seem to not do that anywhere else according to your comment 7 in bug 1861669. This looks great, thanks!
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5e366db01fa6 Remove vibrancy on the osx sidebar. r=desktop-theme-reviewers,dao
|
||
Comment 7•8 months ago
|
||
| bugherder | ||
Description
•