1861726 - Wrong item icons on u.gg (zoom should affect background-image)

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[noszalyaron4]

Attachment: Screenshot from 2023-10-27 19-12-34.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:121.0) Gecko/20100101 Firefox/121.0

Steps to reproduce:

On the latest nightly visit a champion's page on u.gg (e.g https://u.gg/lol/champions/masteryi/build)

Actual results:

Items' icons are wrong

Expected results:

Item icons are correct (as in stable firefox and chrome)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Graphics: WebRender' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Tooru Fujisawa [:arai]]

regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=afe375a5bb0a870f7283fc330c2dc8c8bd2ee965&tochange=793a305aa0628613e6681be3a57c4b089fdecf4c

this is caused by bug 1855763 change, and I see the website is using zoom.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1855763

:emilio, since you are the author of the regressor, bug 1855763, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Yeah this is because zoom should affect the intrinsic size of the background-image.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1861726 - Make StyleImage::GetResolution account for CSS zoom. r=#style,#layout

This fixes rendering of background-image when CSS zoom is in effect.

Note that we want to scale the resolution by the inverse of the
zoom, since having a higher image resolution means that the CSS
size gets shrunk and viceversa.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1861726 - Expose some CSS zoom boilerplate to C++. r=#style,#layout

Not making use of Zoom() / Unzoom() on this patch, but will need it, so
doesn't hurt...

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1861726 - Remove unused StyleImage::GetIntrinsicSize. r=#style,#layout

It doesn't account for various subtleties like aspect ratios etc, so
let's remove it.

Depends on D192131

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/396191ce0f50
Expose some CSS zoom boilerplate to C++. r=boris
https://hg.mozilla.org/integration/autoland/rev/086b8c570386
Remove unused StyleImage::GetIntrinsicSize. r=boris

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/396191ce0f50
https://hg.mozilla.org/mozilla-central/rev/086b8c570386

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37aca45f9c29
Make StyleImage::GetResolution account for CSS zoom. r=layout-reviewers,jfkthame

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/42966 for changes under testing/web-platform/tests

Comment 12

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/37aca45f9c29

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot