1855763 - Enable 'zoom' in Nightly and remove '-moz-transform' (to avoid web compat issues when supporting 'zoom')

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Simon Pieters [:zcorpan]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=390936#c104

This should probably be a pref so it's possible to test with and without support for -moz-transform and so it's easy to change direction if it turns out it's less bad to support -moz-transform.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

It's already a pref (layout.css.prefixes.transforms)

Comment 2

[Simon Pieters [:zcorpan]]

OK nice! Then this bug is about flipping the default value.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1855763 - Disable -moz-transform and enable zoom on Nightly. r=zcorpan

This probably needs a couple test fixes.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1855763 - Automatic fixes to avoid using prefixed transforms in tests. r=#layout

We want to disable prefixed transforms to see if it's feasible to ship
zoom without them.

Make tests use un-prefixed transforms.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

For reference I used the following sed / grep combination for most of the changes above:

function replace() {                                                                                                                                                                                                                                                                                                   
  echo "replacing $1 to $2"
  rg -l "$1" | xargs sed -i -E -e s/"$1"/"$2"/g
}
replace '\-moz-perspective-origin:' 'perspective-origin:'
replace '\-moz-transform:' 'transform:'
# etc

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1855763 - Use another alias other than moz-transform to test use counters, and other manual fix-ups. r=#layout

Depends on D189760

Comment 7

[Emilio Cobos Álvarez (:emilio)]

https://treeherder.mozilla.org/jobs?repo=try&revision=bef304d5f839807c991a9df47ab6ed1d19128eeb

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9e0c6f82d15
Automatic fixes to avoid using prefixed transforms in tests. r=layout-reviewers,jfkthame
https://hg.mozilla.org/integration/autoland/rev/81279ad55cef
Use another alias other than moz-transform to test use counters, and other manual fix-ups. r=layout-reviewers,jfkthame

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d9e0c6f82d15
https://hg.mozilla.org/mozilla-central/rev/81279ad55cef

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:dshin, could you have a look please?

For more information, please visit BugBot documentation.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/facd9f92e1f5
Disable -moz-transform and enable zoom on Nightly. r=zcorpan

Comment 12

[Natalia Csoregi [:nataliaCs]]

Backed out for causing failures on backface-visibility-1b.html

• backout: https://hg.mozilla.org/integration/autoland/rev/1bfcea9b6627b3f166edbc82abe3a90f62c4a417
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=KF77GYcQQA6Csmolkm925g.0&revision=facd9f92e1f57dbadfba1397e8b2463c53729640
• failure log: https://treeherder.mozilla.org/logviewer?job_id=433092486&repo=autoland&lineNumber=10074

Comment 13

[Natalia Csoregi [:nataliaCs]]

Also failing:

• TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | Unused allowlist item: {"sourceName":"/\bscrollbars\.css$/i","errorMessage":"/Unknown property ‘zoom’/i","isFromDevTools":false} -
• TEST-UNEXPECTED-FAIL | /resize-observer/svg.html | test17: observe g:rect content, border and device-pixel-content boxes with zoom - assert_equals: expected 50 but got 4.6833343505859375

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/793a305aa062
Disable -moz-transform and enable zoom on Nightly. r=zcorpan

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0041460ad93
Fix property_database.js to account for transform prefixes.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10dec6063e0e
Add zoom entry to property_database.js

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8d20d2ae8ad
Fix eslint. r=fix CLOSED TREE

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fafeb43eefd1
A couple other mochitest fixes.

Comment 19

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/793a305aa062
https://hg.mozilla.org/mozilla-central/rev/a0041460ad93
https://hg.mozilla.org/mozilla-central/rev/10dec6063e0e
https://hg.mozilla.org/mozilla-central/rev/b8d20d2ae8ad
https://hg.mozilla.org/mozilla-central/rev/fafeb43eefd1

Comment 20

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1855763 - Remove transition prefixes from nightly too. r=zcorpan,#layout

Code like the one from comment 7 seems reasonable. Let's try to disable
prefixed transitions along with prefixed transforms in order to minimize
the compat fallout from CSS zoom.

While I was at it I also fixed the prefixed animation entries in the
property database and crashtests. But those aliases remain enabled.

Comment 21

[Mathew Hodson]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #20)

Created attachment 9360757 [details]
Bug 1855763 - Remove transition prefixes from nightly too. r=zcorpan,#layout

Was this patch supposed to be for bug 1861730?

Comment 22

[Phabricator Automation]

Comment on attachment 9360757 [details]
Bug 1855763 - Remove transition prefixes from nightly too. r=zcorpan,#layout

Revision D192129 was moved to bug 1861730. Setting attachment 9360757 [details] to obsolete.

Comment 23

[Emilio Cobos Álvarez (:emilio)]

Yeah, thanks!

Comment 24

[Brian Thomas Smith [bsmth]]

Docs changes for this can be tracked in the following GitHub issue: https://github.com/mdn/content/issues/29785

Comment 25

[Daniel Holbert [:dholbert]]

For the record, we ended up reverting the "disable -moz-transform" part of this bug -- we reenabled moz-transform styling (about:config pref layout.css.prefixes.transforms in a nightly-only way in bug 1901497 (as part of Nightly 130) and in release in bug 1886134 (as part of Firefox 133).

Comment 26

[Daniel Holbert [:dholbert]]

(adjusting bug summary to make the part-that-stuck [enabling 'zoom'] more up-front in the summary)