1861730 - floating text not work in www.bilibili.tv (assumes that if -moz-transition works then -moz-transform works)

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[mix5003]

Attachment: bilibili_floating_text.h264.mp4

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:121.0) Gecko/20100101 Firefox/121.0

Steps to reproduce:

1. go to some video in bilibili.tv that has floating text (danmaku feature) for example https://www.bilibili.tv/en/play/2090295/12975589
2. enable floating text (danmaku feature)
3. wait for floating text appear

Actual results:

floating text not visible when video play. but if it pause it can see normally

Expected results:

floating text should visible when video playing.

like in my video. first part from chrome it can visible floating text normally. but second part is firefox i can't see any text until i pause video

Comment 1

[mix5003]

info form mozregression

2023-10-28T00:17:32.706000: DEBUG : Found commit message:
Bug 1855763 - Disable -moz-transform and enable zoom on Nightly. r=zcorpan

Disable zoom on a couple tests that otherwise fail. They're known
issues:

• offsetWidth/Height not being unzoomed (button-min-width).
• getComputedStyle not being unzoomed (font-size-interpolation-003.html)
• ResizeObserver box not being unzoomed (https://github.com/w3c/csswg-drafts/issues/9398).

Differential Revision: https://phabricator.services.mozilla.com/D189644

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Audio/Video: Playback' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1855763, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

I can't load the video attached to comment 0, and the link there says "Sorry, according to the request of the copyright owner, this video is not available at the moment.".

Any chance you could provide another URL that shows the issue? Thanks.

Comment 5

[mix5003]

can you try this link (but i think flying text base on region too, so it may not appear in your region)
https://www.bilibili.tv/th/video/4789014123387392
https://www.bilibili.tv/th/video/4789014009878016

or can you pick randomly series in this page https://www.bilibili.tv/en/anime

Comment 6

[mix5003]

i think i can create reproduction case: https://jsfiddle.net/ysdx2fkg/2/

i think key point is use transition: -moz-transform and normal transform css. i am not sure is this your intention or not

and when i change layout.css.prefixes.transforms to true. it fixed this bug.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Okay, so here's the relevant code:

 r.prototype.renderStyle=function(e,i,s){for(var l="",p=0;p<g.browserPrefix.length;p++)l+=g.browserPrefix[p]+"transform: translateX("+(e?1:-1)*i+`px) translateY(0px) translateZ(0px);
            `+g.browserPrefix[p]+"transition: "+g.browserPrefix[p]+"transform "+s+"s linear;";this.element.style.cssText=this.cssTest+l}

Where d.browserPrefix=["","-webkit-","-moz-","-ms-"];. So they're assuming that if -moz-transition works, then -moz-transform works too.

I guess let's try to get rid of the transition prefixes too...

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Can you confirm that changing layout.css.prefixes.transforms back to false, and flipping layout.css.prefixes.transitions too, then it works again?

Comment 9

[mix5003]

yes if i set layout.css.prefixes.transforms and layout.css.prefixes.transitions to false. it can fix this bug.

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Thanks for confirming.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1855763

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1861730 - Remove transition prefixes from nightly too. r=zcorpan,#layout

Code like the one from comment 7 seems reasonable. Let's try to disable
prefixed transitions along with prefixed transforms in order to minimize
the compat fallout from CSS zoom.

While I was at it I also fixed the prefixed animation entries in the
property database and crashtests. But those aliases remain enabled.

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jimm, could you have a look please?

For more information, please visit BugBot documentation.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b403bb5b1c83
Remove transition prefixes from nightly too. r=jwatt

Comment 15

[Cristian Tuns]

Backed out for causing mochitest failures in test_moz_prefixed_properties.html

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | dom/animation/test/mozilla/test_moz_prefixed_properties.html | Finished test - Finished test: Status: 1

And also this: https://treeherder.mozilla.org/logviewer?job_id=436772958&repo=autoland

Comment 16

[Natalia Csoregi [:nataliaCs]]

There are a bunch of other failures, mochitest-plain, which are fixed by the above backout: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=b403bb5b1c833d29961882402a090cf08f44c190&searchStr=mochitest-plain

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ffdf085e5e3c
Remove transition prefixes from nightly too. r=jwatt

Comment 18

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/ffdf085e5e3c