1867854 - Sidebar of the places window looks too light on macOS after bug 1861954

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

Markus mentioned this a couple days ago and I agree. Seems a regression from bug 1861954.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1861954

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1867854 - Improve background color for library window sidebar. r=mstange,#theme

In bug 1861954 I also removed the vibrancy of the places window.

Unlike the browser sidebar this one didn't have an explicit background
color. Add back a system color for the mac sidebar and use it in both
places. This matches the old -moz-mac-source-list color.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1867854 - Remove appearance: dialog. r=mstange,#mac-reviewers

This is not really needed.

It was never needed if you used background-color: transparent, which is what
the browser did to get sidebar vibrancy, fwiw.

Instead of applying transparency globally, opt-into it explicitly for
things that need it (the unified toolbar of the page info / library windows).

I checked the other things that were using it (wizard and updates.css)
and I don't see any rendering change with this change (tried showing the
update history from about:support, and the create profile wizard).

Depends on D195294

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1867854 - Hide some macOS system colors from content. r=mstange,#layout,#style

Mostly drive-by. Hide macOS specific colors from content, and also the native
hyperlinktext color, which isn't and shouldn't be used from CSS at all.

Depends on D195295

Comment 5

[Emilio Cobos Álvarez (:emilio)]

FYI this might need some changes like comment 3 in other thunderbird windows.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d84c3950216
Improve background color for library window sidebar. r=desktop-theme-reviewers,dao

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1705f589239b
Remove appearance: dialog. r=desktop-theme-reviewers,dao

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e8c99f42227
Hide some macOS system colors from content. r=jwatt

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3445cc3f8420
Remove some no-longer-exposed colors from test_bug232227.html.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/566f965cab3d
Remove another leftover usage of appearance: dialog.

Comment 11

[Magnus Melin [:mkmelin]]

Thanks, spun it off to bug 1868081

Comment 12

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/5d84c3950216
https://hg.mozilla.org/mozilla-central/rev/1705f589239b
https://hg.mozilla.org/mozilla-central/rev/9e8c99f42227
https://hg.mozilla.org/mozilla-central/rev/3445cc3f8420
https://hg.mozilla.org/mozilla-central/rev/566f965cab3d

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox121 to wontfix.

For more information, please visit BugBot documentation.

Comment 14

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9366578 [details]
Bug 1867854 - Improve background color for library window sidebar. r=mstange,#theme

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial CSS fix.
• String changes made/needed: none
• Is Android affected?: No

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9366578 [details]
Bug 1867854 - Improve background color for library window sidebar. r=mstange,#theme

Approved for 121.0b8.

Comment 16

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/0fdd8c90220f

Comment 17

[Anca Soncutean, Desktop QA]

Attachment: Screenshot dark theme.png

Light theme
Reproduced with Fx 122 (2023-11-30).
Verified fixed with Fx 122 (2023-12-05) and Fx 121.0b8 (treeherder build), the background is darker.

Dark theme
Note that when dark theme is enabled the background is lighter on the "fixed" build and darker on the older build. Is this expected?

Tested on macOS 13.

Comment 18

[Emilio Cobos Álvarez (:emilio)]

Yes, that's the expected behaviour

Comment 19

[Anca Soncutean, Desktop QA]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #18)

Yes, that's the expected behaviour

Thank you for the confirmation. I will mark this issue as verified fixed.