Sidebar of the places window looks too light on macOS after bug 1861954
Categories
(Firefox :: Theme, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr115 | --- | unaffected |
firefox120 | --- | unaffected |
firefox121 | --- | verified |
firefox122 | --- | verified |
People
(Reporter: emilio, Assigned: emilio)
References
(Regression)
Details
(Keywords: regression)
Attachments
(4 files)
Markus mentioned this a couple days ago and I agree. Seems a regression from bug 1861954.
Comment 1•10 months ago
|
||
Set release status flags based on info from the regressing bug 1861954
Assignee | ||
Comment 2•10 months ago
|
||
In bug 1861954 I also removed the vibrancy of the places window.
Unlike the browser sidebar this one didn't have an explicit background
color. Add back a system color for the mac sidebar and use it in both
places. This matches the old -moz-mac-source-list color.
Assignee | ||
Comment 3•10 months ago
|
||
This is not really needed.
It was never needed if you used background-color: transparent, which is what
the browser did to get sidebar vibrancy, fwiw.
Instead of applying transparency globally, opt-into it explicitly for
things that need it (the unified toolbar of the page info / library windows).
I checked the other things that were using it (wizard and updates.css)
and I don't see any rendering change with this change (tried showing the
update history from about:support, and the create profile wizard).
Depends on D195294
Assignee | ||
Comment 4•10 months ago
|
||
Mostly drive-by. Hide macOS specific colors from content, and also the native
hyperlinktext color, which isn't and shouldn't be used from CSS at all.
Depends on D195295
Assignee | ||
Comment 5•10 months ago
|
||
FYI this might need some changes like comment 3 in other thunderbird windows.
Comment 10•10 months ago
|
||
Comment 12•10 months ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5d84c3950216
https://hg.mozilla.org/mozilla-central/rev/1705f589239b
https://hg.mozilla.org/mozilla-central/rev/9e8c99f42227
https://hg.mozilla.org/mozilla-central/rev/3445cc3f8420
https://hg.mozilla.org/mozilla-central/rev/566f965cab3d
Comment 13•10 months ago
|
||
The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox121
towontfix
.
For more information, please visit BugBot documentation.
Assignee | ||
Comment 14•10 months ago
|
||
Comment on attachment 9366578 [details]
Bug 1867854 - Improve background color for library window sidebar. r=mstange,#theme
Beta/Release Uplift Approval Request
- User impact if declined: comment 0
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: comment 0
- List of other uplifts needed: none
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Trivial CSS fix.
- String changes made/needed: none
- Is Android affected?: No
Assignee | ||
Updated•10 months ago
|
Comment 15•10 months ago
|
||
Comment on attachment 9366578 [details]
Bug 1867854 - Improve background color for library window sidebar. r=mstange,#theme
Approved for 121.0b8.
Comment 16•10 months ago
|
||
uplift |
Updated•10 months ago
|
Updated•10 months ago
|
Comment 17•10 months ago
•
|
||
Light theme
Reproduced with Fx 122 (2023-11-30).
Verified fixed with Fx 122 (2023-12-05) and Fx 121.0b8 (treeherder build), the background is darker.
Dark theme
Note that when dark theme is enabled the background is lighter on the "fixed" build and darker on the older build. Is this expected?
Tested on macOS 13.
Comment 19•10 months ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #18)
Yes, that's the expected behaviour
Thank you for the confirmation. I will mark this issue as verified fixed.
Description
•