1863257 - Remove sync wait in compositor thread of main thread canvas by RemoteTextureMap::WaitForRemoteTextureOwner()

Status: RESOLVED FIXED

(Core :: Graphics, enhancement, P1)

Description

[Sotaro Ikeda [:sotaro]]

Current async RemoteTexture needs sync IPC to ensure first RemoteTexture in RemoteTextureMap. It is nice if the Sync IPC could be removed.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: WIP: Bug 1863257 - Remove sync IPC related to RemoteTexture

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1863257 - Remove sync wait in compositor thread of main thread canvas by RemoteTextureMap::WaitForRemoteTextureOwner()

Comment 3

[Bob Hood [:bhood]]

Setting this to a P1 since it blocks an S2 report.

Comment 4

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/jobs?repo=try&revision=71ad754f46b424a631a4f34c26b915969a94e766

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34a19d66cdca
Remove sync wait in compositor thread of main thread canvas by RemoteTextureMap::WaitForRemoteTextureOwner() r=gfx-reviewers,lsalzman

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/34a19d66cdca

Comment 7

[Sotaro Ikeda [:sotaro]]

Fix caused regression(Bug 1897821). Going to disable async wait of remote texture owner for now by Bug 1897821.

Comment 8

[Andrej (:aglavic)]

(In reply to Sotaro Ikeda [:sotaro] from comment #7)

Fix caused regression(Bug 1897821). Going to disable async wait of remote texture owner for now by Bug 1897821.

As an FYI this bug(1863257) caused a regression and regressed the following:
Perfherder has detected a talos performance change from push 9142f728c689228ac4b5a2f55b2d50a3c5440d1b.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
9%	pdfpaint issue840.pdf	macosx1015-64-shippable-qr	e10s fission stylo webrender	589.55 -> 639.95
4%	pdfpaint tiling-pattern-box.pdf	linux1804-64-shippable-qr	e10s fission stylo webrender	1,739.68 -> 1,813.54

As author of one of the patches included in that push, we need your help to address this regression.
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 383

For more information on performance sheriffing please see our FAQ.

Your followup bug of 1897821 seems to have resolved the issue but I just wanted to bring awareness that enabling async wait could cause a performance regression

Comment 9

[Sotaro Ikeda [:sotaro]]

The change is already disabled once by Bug 1897821. And with several fixes, the sync wait is going to be removed only on Nightly by Bug 1898650.