1897821 - Canvas2d demo disappers instantly after loading (and lots of canvas2d demos either dont render, or flash, or render intermittently)

Status: VERIFIED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Mayank Bansal]

Use latest Nightly on windows
Set the following prefs

gfx.direct2d.disabled = true
gfx.canvas.accelerated = true
gfx.canvas.remote.worker-threads = 0

Go to https://codepen.io/KilledByAPixel/pen/OJqaRjR

AR: The demo disappears
https://share.firefox.dev/4bkWyZg

Comment 1

[Mayank Bansal]

in general, lots of "heavy" demos are showing bizarre behaviour.

https://codepen.io/Mertl/pen/GRdGNJL : Doesnt render anything
https://codepen.io/tsuhre/pen/RwGGrGx : If you keep on slowly resizong the demo pane, the demo stops rendering

Comment 2

[Mayank Bansal]

In general, the browser UI has become very smooth while the demos run, which I absolutely love.

If/when bug 1863257 may be relanded, may i politely suggest to test the open regression from these 3 bugs with both d2d-canvas and gpu-canvas:

bug 1829026, bug 1871467, bug 1863914

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1863257

Comment 4

[Sotaro Ikeda [:sotaro]]

Thank you for the report! I take the bug.

Comment 5

[Sotaro Ikeda [:sotaro]]

Async wait of remote texture owner seemed to work as expected, other parts seemed to cause the problem.

Comment 6

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1897821 - Re-enable wait of remote texture owner in WebRenderImageHost::UseRemoteTexture()

Comment 7

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1897821 - Re-enable wait of remote texture owner in WebRenderImageHost::UseRemoteTexture()

Comment 8

[Sotaro Ikeda [:sotaro]]

(In reply to Mayank Bansal from comment #1)

in general, lots of "heavy" demos are showing bizarre behaviour.

https://codepen.io/Mertl/pen/GRdGNJL : Doesnt render anything

When the problem happened, AsyncImagePipeline did not exist anymore at AsyncImagePipelineManager::ApplyAsyncImageForPipeline().

We also need to defer lifetime of AsyncImagePipeline when remote texture is used.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3202a06939c4
Re-enable wait of remote texture owner in WebRenderImageHost::UseRemoteTexture() r=gfx-reviewers,lsalzman

Comment 10

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/3202a06939c4

Comment 11

[Andrej (:aglavic)]

(In reply to Pulsebot from comment #9)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3202a06939c4
Re-enable wait of remote texture owner in
WebRenderImageHost::UseRemoteTexture() r=gfx-reviewers,lsalzman

Perfherder has detected a talos performance change from push 3202a06939c4312c17408f78f9cb0fa5caca1350.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
5%	pdfpaint tiling-pattern-box.pdf	linux1804-64-shippable-qr	e10s fission stylo webrender	1,814.56 -> 1,722.92

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 463

For more information on performance sheriffing please see our FAQ.

Comment 12

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Issue is reproducible on a 2024-05-20 Nightly build on Windows 10, using the STR and links from Comment 0 and Comment 1.
Verified as fixed on Firefox 128.0b2 and Firefox Nightly 129.0a1 on Windows 10, Ubuntu 22, macOS 14.