Investigate if browser_panelUINotifications_multiWindow in Customizable UI needs to be updated to pass a11y_checks
Categories
(Firefox :: Settings UI, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox121 | --- | fixed |
People
(Reporter: ayeddi, Assigned: ayeddi)
References
Details
Attachments
(1 file)
There is a failing test in the browser/components/customizableui/test/browser_panelUINotifications_multiWindow.js that appear to, in some environments, send a click event on a panel button while the panel itself is still in the showing state.
We should wait for the panel to be shown to keep the test harness happy and to ensure the test is proceeding as it is expected to. Similar behavior was unpacked during the investigation of the bug 1859035.
a11y_checks failing data (with stack trace):
FAIL browser/components/customizableui/test/browser_panelUINotifications_multiWindow.js Node is not focusable via the accessibility API button popup-notification-primary-button primary panel-footer-button "
chrome://mochikit/content/browser-test.js:test_ok:1583
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:a11yFail:339
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertFocusable:382
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertCanBeClicked:667
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:runIfA11YChecks/this.AccessibilityUtils:635
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:handleClick:751
chrome://mochitests/content/browser/browser/components/customizableui/test/browser_panelUINotifications_multiWindow.js:testDoesNotShowDoorhangerForBackgroundWindow/<:62
resource://testing-common/BrowserTestUtils.sys.mjs:withNewTab:146
chrome://mochitests/content/browser/browser/components/customizableui/test/browser_panelUINotifications_multiWindow.js:testDoesNotShowDoorhangerForBackgroundWindow:18
chrome://mochikit/content/browser-test.js:handleTask:1134
chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1206
chrome://mochikit/content/browser-test.js:Tester_execTest:1348
chrome://mochikit/content/browser-test.js:nextTest/<:1123
chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
"
|
Assignee | |
Comment 1•7 months ago
|
||
The test is sending a click to a button on a doorhander that is normally accessible, but the a11y-checks are consistenly failing the test, because in some cases the event is sent while the panel is still showing. We need to wait for the panel to change it's status to open and to observe the popup-shown event to ensure the test is continued as it was expected to.
|
||
Updated•7 months ago
|
Pushed by ayeddi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/740891aba7f0 Wait for a panel to be shown before clicking a button in browser_panelUINotifications_multiWindow. r=Gijs,Jamie
|
||
Comment 3•7 months ago
|
||
| bugherder | ||
Description
•