Block tab audio decoding in content processes in release builds
Categories
(Core :: Audio/Video, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox124 | --- | fixed |
People
(Reporter: gerard-majax, Assigned: gerard-majax)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
As of bug 1850904 we have blocked the ability to perform audio decoding on tab (unless a pref was toggled) in nightly and for early beta in bug 1850904, we should expand this to late beta and release now. This will ride the train.
After careful tylemetry analysis, we can state :
- no audio decoding happening in the wild on beta and nightly on a different process than
utility - for a pair of releases already
- no bug report on those that audio is not working (we had some: bug 1840371, bug 1839852, bug 1856301), given the time this has been on, we hopefully had more feedback if there was a problem
- nightly and early beta are already blocking audio decoding outside of utility, and it's a locked pref on nightly
- release still shows a bit of decoding on
tabprocess
That last point was the major concern. We investigated whether we had another misreport such as bug 1844281 but could not find any. Telemetry shows us that clients reporting audio decoding on the tab process are also reporting utility decoding within the same browsing session ; this means the utility process works for them. One way this could happen is if there's a race between Content exposing its decoding capabilities (that blocking with the current patch will avoid), and Utility exposing its. It took me a while to get to reproduce that in a consistent way, all my previous attempts would block the media startup chain and wait for Utility rather than fallback to Content, but there is a way.
|
Assignee | |
Comment 1•6 months ago
|
||
|
|
Assignee | |
Comment 2•6 months ago
|
||
|
|
Assignee | |
Comment 3•6 months ago
|
||
release sim ipc tests: https://treeherder.mozilla.org/jobs?repo=try&revision=d0339f4dbaff65fd7d80debab1fd636a74fda666
release sim media tests: https://treeherder.mozilla.org/jobs?repo=try&revision=ea2daf4722df34f5e3da82d5ed410bf2134ae373
nightly ipc tests: https://treeherder.mozilla.org/jobs?repo=try&revision=5dd8fbc9e732f1c59f2948ea6c240172281bc5a9
nightly media tests: https://treeherder.mozilla.org/jobs?repo=try&revision=3f11ed96f6c67faf7eac8405816d345b68a75a77
ASAN failure: https://treeherder.mozilla.org/logviewer?job_id=435831074&repo=try&lineNumber=3479 see https://bugzilla.mozilla.org/show_bug.cgi?id=1864165
other M-wmfme(mda) failures reproduce on mozilla-central without my changes: https://treeherder.mozilla.org/jobs?repo=try&revision=b9fdbd5210b02698fd5d19f5fbe99019b4d670ab
|
||
Updated•6 months ago
|
|
|
Assignee | |
Comment 4•4 months ago
|
||
android regresssed ? :( https://treeherder.mozilla.org/jobs?repo=try&revision=5afeaa274626ccd254060d396239497a855e30ca
|
|
Assignee | |
Comment 5•4 months ago
|
||
(In reply to :gerard-majax from comment #4)
android regresssed ? :( https://treeherder.mozilla.org/jobs?repo=try&revision=5afeaa274626ccd254060d396239497a855e30ca
or a mistake during a rebase, which disabled utillity on android :[, new try looks better: https://treeherder.mozilla.org/jobs?repo=try&revision=37143380b27f3b4b853a1d926ae45225b507c82b
Pushed by alissy@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bb44589ad2d9 Block ability to perform audio decoding outside of Utility on release r=padenot
|
||
Updated•3 months ago
|
|
||
Comment 8•3 months ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 9•19 days ago
|
||
This shipped on 124 and as of today, telemetry is all good, no audio decoding reported on tab and we got so far no complaints of missing audio / blocked decoding
Description
•