186413 - History sort order incorrect when left on last visited

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[rsohal]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3a) Gecko/20021207 Phoenix/0.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3a) Gecko/20021207 Phoenix/0.5

If the history sidebar is left on View > by last visited, the list will quickly
become out of order.  Re-selecting By last visited will reorder the list in the
proper order but Phoenix will not remember the change.  Closing and reopening
the history sidebar will cause it to return to the previous, incorrect order. 
The history order in the Go menu is still correct.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Forest]

I observe the same behavior daily.  It is especially odd to see that the Last
Visited View is selected, while the links in the history list are clearly out of
order.  It may be related to Mozilla bug 148539.

(Phoenix 0.5, Windows 2000.)

Comment 2

[Sébastien Delahaye]

Seems OK on build Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4a)
Gecko/20030313 Phoenix/0.5

Reporter, are you still seeing the problem?

Comment 3

[rsohal]

Retested with Phoenix nightly 20020316 under XP.  The problems have gotten stranger:

Set the history view to something other than last visited.
Change it to last visited.
Close and reopen the sidebar.  The order and view is preserved.
Close and reopen the sidebar again.

What is happening now is that even if the view is left on last visited, it
changes to the Date view.  The links within each day in the date view appear to
be in random order (not alphabetical, chronological or by site).  The same
behavior happens under the by site and by most visited views.

If you do not reopen the history sidebar more than once on a given page, it
stays on the correct view and order most of the time.  Eventually, it seems to
convert to the Date view and inherits its problems.  If the history sidebar is
left open while browsing in last visited view, it works properly.  However, the
original problem only occurred when the sidebar was closed and reopened. 
Because of the new problems, I can't tell if the old one was fixed. 

Comment 4

[noririty]

*** Bug 199818 has been marked as a duplicate of this bug. ***

Comment 5

[aynilove [So, Jae-yoon]]

Agree to #3.
Using Gecko/20030327, win95(kor), win.net RC2(eng), #3 is not solved - just
follow above instruction.

Comment 6

[noririty]

Reproduced with 20030329/WinXP.

-> New

Comment 7

[aynilove [So, Jae-yoon]]

simple reproduce.

1. open history sidebar.
2. set history view by last visit.
   (or anything but "by day" and "by day and site")
3. close and reopen sidebar.
4. history is sorted by last visit. (but it's not an end)
5. close and reopen sidebar.
6. history will view by day, regardless of choice in step 2.

Comment 8

[aynilove [So, Jae-yoon]]

Inactived for a while.
In my opinion, it would be fixed until 0.7 milestone..

Comment 9

[noririty]

Attachment: port fix from Bug 91417

Mozilla fixed this issue by Bug 91417.
This is a ported patch to fix this bug.

Comment 10

[rsohal]

Using the patched history.js from #9, I no longer see the original problem or
the problem described in #3 with Firebird 0.6.

Comment 11

[noririty]

rsohal:
Thank you for reviewing.

Reassign to bryner.

Comment 12

[Brian Ryner (not reading)]

Comment on attachment 125754 [details] [diff] [review]
port fix from Bug 91417

Why did you comment out the GroupBy() in unUnload()?

Comment 13

[noririty]

Because we should persist the sort order.
If I call GroupBy() in onUnload(), the sort order you instructed is changed.
This causes mismatch between viewButton's value and actual sort order.

Comment 14

[noririty]

Comment on attachment 125754 [details] [diff] [review]
port fix from Bug 91417

this patch causes another problem when I search then close sidebar.

Comment 15

[Tsukasa Maruyama]

Attachment: patch

this cause is GroupBy() in Unload() worked wrong, and values of
gHistoryGrouping and selectedsort did not correspond. 

1. change history view to last visit
   gHistoryGrouping == none , selectedsort == lastvisited
2. history panel close
   gHistoryGrouping == none , selectedsort == lastvisited
3. history panel open
   gHistoryGrouping == lastvisited
4. history panel close
   gHistoryGrouping == day (not exist 'lastvisited' value in case statement)
5. history panel open
   gHistoryGrouping == day , selectedsort == lastvisited

I fixed to given consistency to GroupBy(), to call selectedsort in unload(),
and to call new groupby() at to initialize history panel.
It seem that it is work well.

Comment 16

[noririty]

I'll take a look about this.

Comment 17

[Steffen Wilberg]

Noririty checked in a fix on 08/01.
Cannot reproduce comment 7 anymore.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030803 Mozilla
Firebird/0.6.1

->fixed.

Comment 18

[Simon Paquet [:sipaq]]

Verified.

Comment 19

[Simon Paquet [:sipaq]]

Verified.