Closed Bug 1867430 Opened 6 months ago Closed 5 months ago

Provide moz-input-box combobox with an accessible name for the browser/components/urlbar/tests/browser/browser_view_selectionByMouse.js to pass Tier 2 a11y-checks

Categories

(Firefox :: Address Bar, defect, P5)

Product:
Firefox
Component:
Address Bar
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
123 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- unaffected
firefox120 --- unaffected
firefox121 --- unaffected
firefox122 --- wontfix
firefox123 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: ayeddi)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: intermittent-failure, intermittent-testcase, regression, Whiteboard: [retriggered])

Attachments

(1 obsolete file)

Filed by: imoraru [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=438219054&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/dQiKz5TfTfykdoB6AFRDnQ/runs/0/artifacts/public/logs/live_backing.log

[task 2023-11-30T00:44:50.655Z] 00:44:50     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_view_selectionByMouse.js | input.value should be as expected - "example.com/initial" == "example.com/initial" - 
[task 2023-11-30T00:44:50.656Z] 00:44:50     INFO - Buffered messages finished
[task 2023-11-30T00:44:50.662Z] 00:44:50     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_view_selectionByMouse.js | Interactive elements must be labeled: id: , tagName: moz-input-box, className: urlbar-input-box - 
[task 2023-11-30T00:44:50.662Z] 00:44:50     INFO - Stack trace:
[task 2023-11-30T00:44:50.662Z] 00:44:50     INFO - chrome://mochikit/content/browser-test.js:test_ok:1587
[task 2023-11-30T00:44:50.662Z] 00:44:50     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:a11yFail:392
[task 2023-11-30T00:44:50.662Z] 00:44:50     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertLabelled:575
[task 2023-11-30T00:44:50.662Z] 00:44:50     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertLabelled/<:564
[task 2023-11-30T00:44:50.662Z] 00:44:50     INFO - EventListener.handleEvent*chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertLabelled:552
[task 2023-11-30T00:44:50.662Z] 00:44:50     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertCanBeClicked:733
[task 2023-11-30T00:44:50.662Z] 00:44:50     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:runIfA11YChecks/this.AccessibilityUtils:700
[task 2023-11-30T00:44:50.662Z] 00:44:50     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:handleEvent:807
[task 2023-11-30T00:44:50.662Z] 00:44:50     INFO - chrome://mochikit/content/tests/SimpleTest/EventUtils.js:synthesizeMouseAtPoint:727
[task 2023-11-30T00:44:50.662Z] 00:44:50     INFO - chrome://mochikit/content/tests/SimpleTest/EventUtils.js:synthesizeMouse:565
[task 2023-11-30T00:44:50.662Z] 00:44:50     INFO - chrome://mochikit/content/tests/SimpleTest/EventUtils.js:synthesizeMouseAtCenter:846
[task 2023-11-30T00:44:50.662Z] 00:44:50     INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_view_selectionByMouse.js:buttons/<:516
[task 2023-11-30T00:44:50.662Z] 00:44:50     INFO - resource://testing-common/BrowserTestUtils.sys.mjs:withNewTab:146
[task 2023-11-30T00:44:50.662Z] 00:44:50     INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_view_selectionByMouse.js:buttons:457
[task 2023-11-30T00:44:50.662Z] 00:44:50     INFO - chrome://mochikit/content/browser-test.js:handleTask:1138
[task 2023-11-30T00:44:50.662Z] 00:44:50     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1210
[task 2023-11-30T00:44:50.662Z] 00:44:50     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1352
[task 2023-11-30T00:44:50.662Z] 00:44:50     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1127
[task 2023-11-30T00:44:50.662Z] 00:44:50     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2023-11-30T00:44:50.663Z] 00:44:50     INFO - Running test with showTopSites = true: Menu button to row-inner
[task 2023-11-30T00:44:50.663Z] 00:44:50     INFO - Console message: [JavaScript Warning: "This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use “<!DOCTYPE html>”." {file: "https://example.com/initial" line: 0}]
[task 2023-11-30T00:44:50.664Z] 00:44:50     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_view_selectionByMouse.js | Sanity check: pageproxystate should be valid initially - "valid" == "valid" -

Hi Anna! Can you please take a look at this?
Thank you!

To get a better overview of the failure rate for this you can check the orange factor from the bug in the see also section Bug 1789051.

Flags: needinfo?(ayeddi)
See Also: → 1789051

Set release status flags based on info from the regressing bug 1864941

status-firefox120: --- → unaffected
status-firefox121: --- → unaffected
status-firefox122: --- → affected
status-firefox-esr115: --- → unaffected
Whiteboard: [retriggered]

Thank you, I’ll send patch shortly

The browser/components/urlbar/tests/browser/browser_view_selectionByMouse.js is failing the a11y-check because the <moz-input-box> combobox does not provide accessible name, which is expected by the WAI ARIA role=combobox specs.

In this case, the user would be focusing the inner input that is properly marked up, but we still want to ensure the markup of the component is compliant with the specs, thus we could be reusing the input's value/placeholder.

Assignee: nobody → ayeddi
Blocks: 1854661
Flags: needinfo?(ayeddi)
See Also: → 1854660, 1692110, a11y_checks_labeled, a11y_checks_disabling
Summary: Perma a11y checks [tier 2] TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_view_selectionByMouse.js | Interactive elements must be labeled: id: , tagName: moz-input-box, className: urlbar-input-box - → Provide moz-input-box combobox with an accessible name for the browser/components/urlbar/tests/browser/browser_view_selectionByMouse.js to pass Tier 2 a11y-checks

The browser/components/urlbar/tests/browser/browser_view_selectionByMouse.js is failing the a11y-check because the <moz-input-box> combobox does not provide accessible name, which is expected by the WAI ARIA role=combobox specs.

In this case, the user would be focusing the inner input that is properly marked up, but we still want to ensure the markup of the component is compliant with the specs, thus we could be reusing the input's value/placeholder.

Attachment #9366937 - Attachment description: Bug 1867430 - Provide moz-input-box combobox with an accessible name for the browser/components/urlbar/tests/browser/browser_view_selectionByMouse.js to pass Tier 2 a11y-checks. r=Jamie! → Bug 1867430 - Provide moz-input-box combobox with an accessible name for the 3 browser tests to pass Tier 2 a11y-checks. r=Jamie!
Blocks: 1789051

Set release status flags based on info from the regressing bug 1864941

status-firefox123: --- → affected
Attachment #9366937 - Attachment is obsolete: true

The patch for bug 1871491 landed yesterday and this issue should be resolved in today's central https://hg.mozilla.org/mozilla-central/rev/ac7e380f9581

Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
status-firefox122: affected → wontfix
status-firefox123: affected → fixed
Target Milestone: --- → 123 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: