1865332 - Canvas animation can't be zoomed in

Status: VERIFIED FIXED

(Core :: DOM: Bindings (WebIDL), defect)

Description

[Simona Badau, Desktop QA]

Attachment: Screen Recording with the issue

Found in

• Nightly 121.0a1

Affected versions

• Nightly 121.01

Tested platforms

• Affected platforms: macOS 11.7, Windows 10, Ubuntu 22.04

Steps to reproduce

1. Navigate to: http://www.effectgames.com/demos/canvascycle/?sound=0
2. Click on Show Option -> Max (from the ZOOM section).

Expected result

• The Canvas animation should be zoomed in.

Actual result

• The canvas animation remains unchanged in size. For additional details, please see the attached screen recording.

Regression range
Found commit message:
Bug 1855763 - Disable -moz-transform and enable zoom on Nightly. r=zcorpan
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=afe375a5bb0a870f7283fc330c2dc8c8bd2ee965&tochange=793a305aa0628613e6681be3a57c4b089fdecf4c

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1855763, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Why tho :'(

if (ua.webkit) sty.webkitTransform = 'translate3d(0px, 0px, 0px) scale('+this.contentSize.scale+')';
else if (ua.ff) sty.MozTransform = 'scale('+this.contentSize.scale+')';
else if (ua.op) sty.OTransform = 'scale('+this.contentSize.scale+')';
else sty.transform = 'scale('+this.contentSize.scale+')';

More -moz-transform fallout...

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1865332 - Expose MozTransform in CSSStyleDeclaration unconditionally. r=#layout,zcorpan,twisniewski

Shipping CSS zoom requires to remove -moz-transform from stylesheets.
That's generally fine, however we've seen a bunch of regressions due to
sites doing broken feature detection in JS (see bugs mentioned in the
patch).

It seems like exposing MozTransform in CSSStyleDeclaration is a
requirement, for some pages.

We could expose it conditionally with some sort of reverse origin trial
or what not, but given the amount of regressions only on Nightly, and
that this is harmless if you do proper feature detection, I think I'd
rather expose it unconditionally, rather than playing whack-a-mole
fixing pages after the fact.

Note that this change currently only affects behavior on Nightly,
because on other release channels -moz-transform is enabled right now.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d92146952904
Expose MozTransform in CSSStyleDeclaration unconditionally. r=jwatt

Comment 6

[Cristian Tuns]

Backed out for causing wpt failures in CSS-supports-CSSStyleDeclaration.html

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | /css/css-conditional/js/CSS-supports-CSSStyleDeclaration.html | -moz-transform: _camel_cased_attribute v. CSS.supports - assert_equals: expected true but got false
  TEST-UNEXPECTED-FAIL | /css/css-conditional/js/CSS-supports-CSSStyleDeclaration.html | -moz-transform: _dashed_attribute v. CSS.supports - assert_equals: expected true but got false

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de35cb5de975
Expose MozTransform in CSSStyleDeclaration unconditionally. r=jwatt

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/de35cb5de975

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43289 for changes under testing/web-platform/tests

Comment 10

[Simona Badau, Desktop QA]

Verified as fixed on the latest Nightly 122.oa1 on Ubuntu 22.04 x64, macOS 11.7, and Windows 10.

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot