Re-add option to disable Pause Debugger Overlay
Categories
(DevTools :: Debugger, enhancement, P3)
Tracking
(firefox125 fixed)
| Tracking | Status | |
|---|---|---|
| firefox125 | --- | fixed |
People
(Reporter: sebo, Assigned: ochameau)
References
(Blocks 2 open bugs)
Details
Attachments
(2 files)
Previously, there was a preference called devtools.debugger.features.overlay allowing to disable the Pause Debugger Overlay including its backdrop. This feature was removed together with other preferences in bug 1831358.
This caused some irritation among developers wondering how they can disable the overlay now.
Therefore, this feature should be added back.
Sebastian
|
||
Comment 1•5 months ago
|
||
Thanks Sebo,
It might be nice to add a button to disable it directly on the overlay so it's easy to turn off.
WE migth have a look at it at the same time we look at the other overlay issues
|
Assignee | |
Updated•5 months ago
|
|
|
Assignee | |
Comment 3•2 months ago
|
||
By protocol.js conventions, most target scopes actors have a targetActor attribute set to their parent,
i.e. the related target actor. Thread Actor was old enough to not follow this pattern.
Also remove the second constructor argument and global attribute as it was unused.
|
|
Assignee | |
Comment 4•2 months ago
|
||
devtools.debugger.features.overlay boolean preference will control this paused overlay.
(same name as an old preference which used to do that)
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7040aeead38a [devtools] Rename ThreadActor's `_parent` to `targetActor`. r=devtools-reviewers,nchevobbe https://hg.mozilla.org/integration/autoland/rev/235663daaeb4 [devtools] Re-introduce a preference to allow disabling the debugger overlay displayed on paused. r=devtools-reviewers,nchevobbe
|
||
Comment 6•2 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7040aeead38a
https://hg.mozilla.org/mozilla-central/rev/235663daaeb4
|
|
||
Comment 7•2 months ago
|
||
Alex, I'm seeing a pretty big regression which points to a pushlog these patches are in. Could you check if this is the regressor please?
== Change summary for alert #41547 (as of Thu, 22 Feb 2024 14:15:10 GMT) ==
Regressions:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 76% | damp custom.jsdebugger.preview.DAMP | linux1804-64-shippable-qr | e10s fission stylo webrender | 387.99 -> 682.34 |
| 19% | damp custom.jsdebugger.stepInNewSource.DAMP | linux1804-64-shippable-qr | e10s fission stylo webrender | 2,619.15 -> 3,116.52 |
| 4% | damp browser-toolbox.debugger-ready.DAMP | linux1804-64-shippable-qr | e10s fission stylo webrender-sw | 1,068.19 -> 1,106.41 |
| 4% | damp simple.jsdebugger.reload.DAMP | linux1804-64-shippable-qr | e10s fission stylo webrender | 223.99 -> 231.98 |
Improvements:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 6% | damp simple.styleeditor.open.DAMP | macosx1015-64-shippable-qr | e10s fission stylo webrender-sw | 120.99 -> 113.97 |
| 3% | damp simple.styleeditor.open.DAMP | windows10-64-shippable-qr | e10s fission stylo webrender | 136.41 -> 132.07 |
| 3% | damp custom.netmonitor.open.DAMP | macosx1015-64-shippable-qr | e10s fission stylo webrender | 182.37 -> 176.82 |
| 3% | damp simple.inspector.open.DAMP | windows10-64-shippable-qr | e10s fission stylo webrender | 229.24 -> 222.75 |
| 2% | damp inspector.layout.open | windows10-64-shippable-qr | e10s fission stylo webrender | 227.24 -> 222.37 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=41547
Description
•