Please add Meiryo font to the blacklist which have wrong underline offset
Categories
(Core :: Layout: Text and Fonts, defect)
Tracking
()
People
(Reporter: tookunana, Unassigned)
References
Details
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:121.0) Gecko/20100101 Firefox/121.0
Steps to reproduce:
When I access Youtube, "Read more" keeps appearing at the bottom.
https://bugzilla.mozilla.org/show_bug.cgi?id=1703084
After adding Meiryo to font.blacklist.underline_offset, "Read more" disappeared
|
||
Comment 1•2 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Core::Layout: Text and Fonts' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.
|
||
Comment 2•2 years ago
|
||
jfkthame or masayuki, I think this is in your wheelhouse, when you've got cycles. (Looks like this font.blacklist.underline_offset pref is from bug 417014 and bug 541924 .)
|
|
||
Comment 3•2 years ago
|
||
it sounds like this fixes bug 1703084, based on comment 0 here and bug 1703084 comment 4. --> adding dependency.
Presumably there are underlines in the text here, which introduce some sort of visual overflow due to weird/unexpected metrics in this font; and that causes YouTube to clip the overflow and add a "Read More" link to show the overflowing content. (But if we blacklist the font and get proper metrics or whatever, then the overflow doesn't happen.)
|
||
Comment 4•2 years ago
•
|
||
No, adding "Meiryo" to the pref does not fix bug 1703084 completely in non-100% DPI displays. And I don't think the underline offset of Meiryo is bad. So, doing this only for specific web page must be wrong approach.
|
|
||
Comment 5•2 years ago
|
||
FYI: Meiryo has bigger leading than usual fonts. That could affect to the overflow rect even though the line-height is computed as 20px in both browsers.
|
|
||
Comment 6•2 years ago
|
||
Setting the line-height to 21px, the layout becomes as expected. So I think that 20px is too tight for Meiryo or there is a rounding issue in our size computation in nscoord coordinates.
|
|
||
Comment 7•2 years ago
|
||
If I load a video which has many comments, I see the bug at some comments, but the others rendered as expected. So, height computation in nscoord might cause the bug. So, this could be content box version of bug 287624.
|
||
Comment 8•2 years ago
|
||
This seems to be basically the same issue as bug 1848367, related to Meiryo line-height computation.
Description
•