1868235 - Update searchfox to handle new SpiderMonkey 1-based columns (previously was 0-based)

Status: RESOLVED FIXED

(Webtools :: Searchfox, task)

Description

[Andrew Sutherland [:asuth] (he/him)]

Bug 1862692 changed SpiderMonkey to use 1-based columns instead of 0-based columns. This regressed source listing behavior because our formatter logic wants its tokenized symbols to line up with the analysis symbols it hears about, so source listing lost their semantic hookup. Search was fine-ish, however since crossref doesn't do any consistency checks. That said, highlights were probably wrong.

We didn't detect this because we didn't have any production checks for mozilla-central for JS. Checks in mozsearch did notice this, but not immediately because we only update the JS shell in our local VMs on provision, whereas the indexers update the JS shell on every run.

We can/should add checks that would detect this more eagerly. There are broadly two options here, both of which are possible:

• Add production checks to m-c.
• Bug 1858453 on making sure we index mozsearch and mozsearch-mozilla. mozsearch's own checks would have caught this. We might want to configure this to keep going rather than halting, though, at least if it's on config1 (which it probably should be).

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Attachment: landed mozsearch PR