1862692 - Switch to 1-origin column number types while keeping the observable behavior

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

In order to migrate to 1-origin column number everywhere, we first need to remove the code that uses 0-origin column number internally, while keeping the observable behavior such as debugger, error message, stack trace, etc.
once the 0-origin column number type consumers are all rewritten, then we can rewrite each input/ouput to use 1-origin value.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1862692 - Part 1: Use 1-origin column number types in FrameIter. r?iain!

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1862692 - Part 2: Use 1-origin column number types in wasm debug. r?iain!

Depends on D193014

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1862692 - Part 3: Use 1-origin column number types in PCToLineNumber. r?iain!

Depends on D193015

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1862692 - Part 4: Use 1-origin column number types in JitCodeAPI. r?iain!

Depends on D193016

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1862692 - Part 5: Use 1-origin column number types in ErrorMetadata. r?iain!

Depends on D193017

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1862692 - Part 6: Use Use 1-origin column number types in EitherParser::computeLineAndColumn. r?iain!

Depends on D193018

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1862692 - Part 7: Use Use 1-origin column number types in CheckPatternSyntax. r?iain!

Depends on D193019

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1862692 - Part 8: Use dedicate type for TokenStream-internal unsigned column number offset. r?iain!

Depends on D193020

Comment 9

[Tooru Fujisawa [:arai]]

Attachment: Bug 1862692 - Part 9: Use 1-origin column number type in ErrorReporter. r?iain!

Depends on D193021

Comment 10

[Tooru Fujisawa [:arai]]

Attachment: Bug 1862692 - Part 10: Use 1-origin column number type in BytecodeSection. r?iain!

Depends on D193022

Comment 11

[Tooru Fujisawa [:arai]]

Attachment: Bug 1862692 - Part 11: Remove unused include in StencilXdr.cpp. r?iain!

Depends on D193023

Comment 12

[Tooru Fujisawa [:arai]]

Attachment: Bug 1862692 - Part 12: Use 1-origin column number type in BytecodeRangeWithPosition. r?iain!

Depends on D193024

Comment 13

[Tooru Fujisawa [:arai]]

Attachment: Bug 1862692 - Part 13: Use 1-origin column number type in source notes. r?iain!

Depends on D193025

Comment 14

[Tooru Fujisawa [:arai]]

Attachment: Bug 1862692 - Part 14: Use 1-origin column number type in SourceExtent. r?iain!

Depends on D193026

Comment 15

[Tooru Fujisawa [:arai]]

Attachment: Bug 1862692 - Part 15: Use 1-origin column number type in JSScript/ScriptSource. r?iain!

Depends on D193027

Comment 16

[Tooru Fujisawa [:arai]]

Attachment: Bug 1862692 - Part 16: Use 1-origin column number type in JS::DescribeScriptedCaller. r?iain!

Depends on D193028

Comment 17

[Tooru Fujisawa [:arai]]

Attachment: Bug 1862692 - Part 17: Use 1-origin column number type in JS::ReadOnlyCompileOptions. r?iain!

Depends on D193029

Comment 18

[Tooru Fujisawa [:arai]]

Attachment: Bug 1862692 - Part 18: Use 1-origin column number type in Debugger. r?iain!

Depends on D193030

Comment 19

[Tooru Fujisawa [:arai]]

Attachment: Bug 1862692 - Part 19: Use 1-origin column number in FlowGraphSummary. r?iain!

Depends on D193031

Comment 20

[Tooru Fujisawa [:arai]]

Attachment: Bug 1862692 - Part 20: Stop using 0-origin column number types. r?iain!

Depends on D193032

Comment 21

[Tooru Fujisawa [:arai]]

Attachment: Bug 1862692 - Part 21: Remove 0-origin column number types. r?iain!

Depends on D193033

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e3ba3664bf7
Part 1: Use 1-origin column number types in FrameIter. r=iain
https://hg.mozilla.org/integration/autoland/rev/26c544b6ed38
Part 2: Use 1-origin column number types in wasm debug. r=iain
https://hg.mozilla.org/integration/autoland/rev/d04f0010a047
Part 3: Use 1-origin column number types in PCToLineNumber. r=iain,profiler-reviewers,canaltinova
https://hg.mozilla.org/integration/autoland/rev/b79dd8b22520
Part 4: Use 1-origin column number types in JitCodeAPI. r=iain
https://hg.mozilla.org/integration/autoland/rev/78de8d84e318
Part 5: Use 1-origin column number types in ErrorMetadata. r=iain
https://hg.mozilla.org/integration/autoland/rev/096d63e38f6e
Part 6: Use Use 1-origin column number types in EitherParser::computeLineAndColumn. r=iain
https://hg.mozilla.org/integration/autoland/rev/3ad1c829d98e
Part 7: Use Use 1-origin column number types in CheckPatternSyntax. r=iain
https://hg.mozilla.org/integration/autoland/rev/15b7a0bc14e4
Part 8: Use dedicate type for TokenStream-internal unsigned column number offset. r=iain
https://hg.mozilla.org/integration/autoland/rev/cf0b05d96802
Part 9: Use 1-origin column number type in ErrorReporter. r=iain
https://hg.mozilla.org/integration/autoland/rev/d24d93ce5b21
Part 10: Use 1-origin column number type in BytecodeSection. r=iain
https://hg.mozilla.org/integration/autoland/rev/f06e4b2ce239
Part 11: Remove unused include in StencilXdr.cpp. r=iain
https://hg.mozilla.org/integration/autoland/rev/71edf12b8008
Part 12: Use 1-origin column number type in BytecodeRangeWithPosition. r=iain
https://hg.mozilla.org/integration/autoland/rev/fd987f5e234d
Part 13: Use 1-origin column number type in source notes. r=iain
https://hg.mozilla.org/integration/autoland/rev/1312dfc6316b
Part 14: Use 1-origin column number type in SourceExtent. r=iain
https://hg.mozilla.org/integration/autoland/rev/ba89b6cdbd7a
Part 15: Use 1-origin column number type in JSScript/ScriptSource. r=iain
https://hg.mozilla.org/integration/autoland/rev/ec3af6f6844f
Part 16: Use 1-origin column number type in JS::DescribeScriptedCaller. r=iain
https://hg.mozilla.org/integration/autoland/rev/86c841c5560d
Part 17: Use 1-origin column number type in JS::ReadOnlyCompileOptions. r=iain
https://hg.mozilla.org/integration/autoland/rev/b5b2cb2edec4
Part 18: Use 1-origin column number type in Debugger. r=iain
https://hg.mozilla.org/integration/autoland/rev/567302fc3a87
Part 19: Use 1-origin column number in FlowGraphSummary. r=iain
https://hg.mozilla.org/integration/autoland/rev/81cd306f2987
Part 20: Stop using 0-origin column number types. r=iain
https://hg.mozilla.org/integration/autoland/rev/02a286ff5192
Part 21: Remove 0-origin column number types. r=iain

Comment 23

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/0e3ba3664bf7
https://hg.mozilla.org/mozilla-central/rev/26c544b6ed38
https://hg.mozilla.org/mozilla-central/rev/d04f0010a047
https://hg.mozilla.org/mozilla-central/rev/b79dd8b22520
https://hg.mozilla.org/mozilla-central/rev/78de8d84e318
https://hg.mozilla.org/mozilla-central/rev/096d63e38f6e
https://hg.mozilla.org/mozilla-central/rev/3ad1c829d98e
https://hg.mozilla.org/mozilla-central/rev/15b7a0bc14e4
https://hg.mozilla.org/mozilla-central/rev/cf0b05d96802
https://hg.mozilla.org/mozilla-central/rev/d24d93ce5b21
https://hg.mozilla.org/mozilla-central/rev/f06e4b2ce239
https://hg.mozilla.org/mozilla-central/rev/71edf12b8008
https://hg.mozilla.org/mozilla-central/rev/fd987f5e234d
https://hg.mozilla.org/mozilla-central/rev/1312dfc6316b
https://hg.mozilla.org/mozilla-central/rev/ba89b6cdbd7a
https://hg.mozilla.org/mozilla-central/rev/ec3af6f6844f
https://hg.mozilla.org/mozilla-central/rev/86c841c5560d
https://hg.mozilla.org/mozilla-central/rev/b5b2cb2edec4
https://hg.mozilla.org/mozilla-central/rev/567302fc3a87
https://hg.mozilla.org/mozilla-central/rev/81cd306f2987
https://hg.mozilla.org/mozilla-central/rev/02a286ff5192