1868794 - Applying Grouped By view directly after reversing sort order is broken

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Hartmut Welpmann [:welpy-cw]]

+++ This bug was initially created as a clone of Bug #1860322 +++

Steps to reproduce:

1. Enter a folder and "Sort by" "Threaded" or "Unthreaded".
2. Reverse the sort order by clicking on the column header.
3. Enable "Sort by" "Grouped by Sort".

Expected results:
Messages should appear grouped under the various dummy rows.

Actual results:
Messages are grouped incorrectly, sometimes messages appear without a dummy row above them.

Comment 1

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1868794 - Skip applying additional sort order after creating a Grouped By view. r=mkmelin

The fix for bug 1860322 prevents a Grouped By view from being created with an invalid sort type.
This disables resorting of the view immediately afterwards, which is unnecessary and upsets the
view under certain circumstances.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dc015312a231
Skip applying additional sort order after creating a Grouped By view. r=mkmelin

Comment 3

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9367483 [details]
Bug 1868794 - Skip applying additional sort order after creating a Grouped By view. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): This does not seem to have ever worked before (at least not in 102).
User impact if declined: Grouped view appearing broken under certain circumstances.
Testing completed (on c-c, etc.): c-c and beta
Risk to taking this patch (and alternatives if risky): very low

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9367483 [details]
Bug 1868794 - Skip applying additional sort order after creating a Grouped By view. r=mkmelin

[Triage Comment]
Approved for esr115

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 115.6.1:
https://hg.mozilla.org/releases/comm-esr115/rev/4b23dacc673d