1860322 - Grouped By view breaks after reversing sort order and applying quick search

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Hartmut Welpmann [:welpy-cw]]

STR:

1. Enter a folder and apply Grouped By Sort and sorted by date.
2. Reverse the sort order by clicking on the date column header.
3. Quick search for any term.

Expected results:
Messages containing the entered search term are displayed.

Actual results:
Nothing is displayed in the thread pane, even after leaving quick search. Only after selecting another folder and coming back, messages are shown again.

Error console contains

Uncaught NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIMsgDBView.open]
    _createView resource:///modules/DBViewWrapper.jsm:1153
    _applyViewChanges resource:///modules/DBViewWrapper.jsm:1505
    set userTerms resource:///modules/SearchSpec.jsm:313
    updateSearch chrome://messenger/content/quickFilterBar.js:508
    deferredUpdateSearch chrome://messenger/content/quickFilterBar.js:475
DBViewWrapper.jsm:1153
``

Comment 1

[Hartmut Welpmann [:welpy-cw]]

This seems to be caused by DBViewWrapper.magicSort applying a secondarySortType that nsMsgGroupView cannot handle. See attached patch.

Comment 2

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1860322 - Disregard secondary sort order for Grouped By views. r=#thunderbird-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ecf34cefd7ef
Disregard secondary sort order for Grouped By views. r=darktrojan

Comment 4

[Wayne Mery (:wsmwk)]

good for 115?

I've seen support requests about this.

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9359593 [details]
Bug 1860322 - Disregard secondary sort order for Grouped By views. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 115.5.2:
https://hg.mozilla.org/releases/comm-esr115/rev/2c6c9b677fcc

Comment 7

[Rob Lemley [:rjl]]

Backout Thunderbird 115.5.2:
https://hg.mozilla.org/releases/comm-esr115/rev/365ffd578743

Comment 8

[Rob Lemley [:rjl]]

This caused problems on esr115. A new patch is needed.

https://treeherder.mozilla.org/logviewer?job_id=439227183&repo=comm-esr115

Comment 9

[Hartmut Welpmann [:welpy-cw]]

Line 17 of the now backed out changeset removes

let outCount = {};

which my patch for comm-central does not.

Comment 10

[Rob Lemley [:rjl]]

my fault! thanks for checking. i will repush.

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 115.5.2:
https://hg.mozilla.org/releases/comm-esr115/rev/645d83496cba