Switching to the thread pane of a folder by keyboard should focus the top visible message.
Categories
(Thunderbird :: Folder and Message Lists, defect)
Tracking
(thunderbird_esr115? fixed, thunderbird122? fixed)
People
(Reporter: welpy-cw, Assigned: welpy-cw)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
48 bytes,
text/x-phabricator-request
|
wsmwk
:
approval-comm-beta+
wsmwk
:
approval-comm-esr115+
|
Details | Review |
Steps to reproduce:
- Select a folder containing messages sorted by date in ascending order, none of which have been selected previously.
- Press F6 to switch to the thread pane.
Actual result:
The view scrolls all the way to the top and the first row is selected.
Expected result:
The last row, which has been scrolled into view, should be focused, but not selected (with the current index as indicated by the dotted border)
The expected result is similar to the behavior of Thunderbird 102, where the topmost visible message is focused.
Comment 1•1 year ago
|
||
Please note that it's not always the last message which is needed when focusing to message list - pre-Supernova versions restored the last message position well even if that was somewhere in the middle.
Assignee | ||
Comment 2•1 year ago
|
||
Updated•1 year ago
|
Assignee | ||
Comment 3•1 year ago
|
||
(In reply to thedonpedro from comment #1)
Please note that it's not always the last message which is needed when focusing to message list - pre-Supernova versions restored the last message position well even if that was somewhere in the middle.
Yes, I'm aware of that. This isn't meant to be a fix for bug 1864911, but it should at least improve the situation there for now. Unfortunately, completely fixing the related bug is much more complicated.
Updated•1 year ago
|
Assignee | ||
Comment 4•1 year ago
|
||
When a tree view (thread pane or address book's cards pane) without any previous selections
receives focus by pressing F6 or Tab, this sets focus to the first visible row, instead of
selecting the first row of all as before.
Assignee | ||
Comment 5•1 year ago
|
||
There were several problems with the approach used in my first patch, so I abandoned it. The new patch changes the way TreeView
reacts on receiving the F6 or Tab key when no rows have focus/are selected yet. Instead of selecting the first row, the top visible row is focused, but not selected. This solves the problem described in the first comment and matches the behavior of Thunderbird 102 as far as the thread pane is concerned. Switching to the cards pane in the address book also only gives focus to the first card, not a selection. This seems to be handled differently in earlier Thunderbird ESRs.
What are these changes from an ARIA perspective? The guidelines seem to support this behavior, but I don't know if this is the way Thunderbird is supposed to work.
Comment 6•1 year ago
|
||
(In reply to Hartmut Welpmann [:welpy-cw] from comment #5)
Hi. Thanks for your work on this. I will test this and let you know the impact.
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Updated•1 year ago
|
Pushed by alessandro@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/bc10b7559d18
Focus (not select) row when tree view gets focus by keyboard. r=aleca
Updated•1 year ago
|
Assignee | ||
Comment 8•11 months ago
|
||
Comment on attachment 9369005 [details]
Bug 1869557 - Focus (not select) row when tree view gets focus by keyboard. r=#thunderbird-front-end-reviewers
[Approval Request Comment]
User impact if declined: Switching to the thread pane by F6 may cause unwanted scrolling.
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low
Comment 9•11 months ago
|
||
Comment on attachment 9369005 [details]
Bug 1869557 - Focus (not select) row when tree view gets focus by keyboard. r=#thunderbird-front-end-reviewers
[Triage Comment]
Approved for beta
Comment 10•11 months ago
|
||
bugherder uplift |
Thunderbird 122.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/a91b4813067e
Assignee | ||
Comment 11•10 months ago
|
||
Comment on attachment 9369005 [details]
Bug 1869557 - Focus (not select) row when tree view gets focus by keyboard. r=#thunderbird-front-end-reviewers
[Approval Request Comment]
User impact if declined: Switching to the thread pane by F6 may cause unwanted scrolling.
Testing completed (on c-c, etc.): c-c and beta
Risk to taking this patch (and alternatives if risky): very low
Comment 12•10 months ago
|
||
Comment on attachment 9369005 [details]
Bug 1869557 - Focus (not select) row when tree view gets focus by keyboard. r=#thunderbird-front-end-reviewers
[Triage Comment]
Approved for esr115
Comment 13•10 months ago
|
||
bugherder uplift |
Thunderbird 115.8.0:
https://hg.mozilla.org/releases/comm-esr115/rev/58d1b7d49a23
Description
•