1869767 - The Delete button and Color picker from each Highlight should disappear when the user moves the mouse cursor away from the Highlight

Status: NEW

(Firefox :: PDF Viewer, enhancement)

Description

[Rares Doghi, Desktop QA]

Attachment: UnderneathColor.mp4

Found in

• Nightly 122.0a1 (2023-12-13)

Affected versions

• Nightly 122.0a1 (2023-12-13)

Affected platforms

• all

Steps to reproduce

1. Open a PDF file with text in Firefox.
2. Enable the Highlight tool.
3. Highlight any text.
4. Move the mouse cursor away from the Highlighted text.

Expected result

• The Delete icon and Color picker should Fade away when the user moves the mouse cursor away from the Highlight.
• Moving the mouse cursor on top of the Highlighted text should Show the Delete icon and color picker again with a Fade in animation.

Actual result

• The Delete icon and Color picker is always displayed for the last Highlighted text, This would cause issues if the user would like to Highlight the text underneath.
  The user has to disable and enable the tool again in order to see the text from the next row without the Delete and Color picker on top.

Regression range
N/A

Comment 1

[Rares Doghi, Desktop QA]

Please note that a similar behavior should be used for the Highlight submenu, on Smaller screens the Color submenu is blocking the Text from the top of the page. I will attach a screenshot.

Comment 2

[Rares Doghi, Desktop QA]

Attachment: Resized.png

Comment 3

[Ryan Casey]

Thanks for flagging, Rares. UX is working on a holistic plan to address this and other tool management issues. I agree what obstructing text, and having to disable the button in the toolbar is problematic. There is also an issue of being able to select a highlight while another tool is enabled, but not the other way around. I will add this to our audit.

Comment 4

[Calixte Denizet (:calixte)]

:Ryan, could we at least unselect the highlight in clicking somewhere on screen (it's something we already do for image) ?
It's far from perfect but at least it provides a way to hide local toolbar, that said it's possible to do it in hitting the Esc key but I guess that most of the users are not used to use their keyboard.

Comment 5

[Ryan Casey]

Agreed, Calixte. The other tools are somewhat inconsistent but I think your description of a fix makes the most sense for now. Thanks

Comment 6

[BMO Github Automation]

Attachment: [mozilla/pdf.js] [Editor] Unselect highlights when the user click on the text layer (bug 1869767) (#17543)

Comment 7

[Marco Castelluccio [:marco]]

Calixte's fix makes this slightly better. We can keep the bug open to consider this in the future when we do a holistic redesign of the editing features.