Closed
Bug 1869853
Opened 2 years ago
Closed 2 years ago
Window transparency logic got reversed after refactoring
Categories
(Core :: Widget: Cocoa, defect)
Core
Widget: Cocoa
Tracking
()
RESOLVED
FIXED
122 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr115 | --- | unaffected |
| firefox120 | --- | unaffected |
| firefox121 | --- | unaffected |
| firefox122 | --- | fixed |
People
(Reporter: sev, Assigned: sev)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
As part of a rewrite of the window transparency logic https://searchfox.org/mozilla-central/source/widget/cocoa/nsCocoaWindow.mm#1239 :
-BOOL currentTransparency = ![mWindow isOpaque];
+BOOL currentTransparency = mWindow.isOpaque;
the "not" part got omitted.
|
Assignee | |
Comment 1•2 years ago
|
||
One-liner to fix the accidental omission of the "not" sign in window
transparency logic.
|
||
Updated•2 years ago
|
Assignee: nobody → sev
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f6bc1cd43803
Reversed window transparency logic r=emilio
|
||
Updated•2 years ago
|
status-firefox120:
--- → unaffected
status-firefox121:
--- → unaffected
status-firefox122:
--- → affected
status-firefox-esr115:
--- → unaffected
Keywords: regression
Regressed by: 1867659
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•