1870014 - Port bug 1869051 - Remove unused strings from passwordmgr.properties

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, task)

Description

[Magnus Melin [:mkmelin]]

Bug 1869051 removed some strings that Thunderbird had borrowed (well, kept using after toolkit dropped some of the functionality).

This is causing

[task 2023-12-14T11:00:24.064Z] 11:00:24     INFO - TEST-PASS | comm/mail/components/addrbook/test/browser/browser_cardDAV_init.js | Correct status message - "carddav-loading" == "carddav-loading" - 
[task 2023-12-14T11:00:24.065Z] 11:00:24     INFO - Console message: [JavaScript Error: "NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]" {file: "resource:///modules/CardDAVUtils.jsm" line: 648}]
[task 2023-12-14T11:00:24.065Z] 11:00:24     INFO - promptAuth@resource:///modules/CardDAVUtils.jsm:648:10

But I think some other places may need change as well. https://searchfox.org/comm-central/search?q=passwordmgr.properties&path=mail&case=false&regexp=false

Comment 1

[Janika Neuberger (:janikaneuberger)]

@mkmelin I can ask for this patch to be backed out again if the strings and translations are still in use in Thunderbird. Would that help?

Comment 2

[Magnus Melin [:mkmelin]]

Thanks. We shouldn't really re-use string that are not "ours" so I think it's best to fix that properly. Seems like it's just one string.

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: Bug 1870014 - Port bug 1869051 - use our own string for "Remember password". r=#thunderbird-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/aa1bf7240c08
Port bug 1869051 - use our own string for "Remember password". r=aleca

Comment 6

[Intermittent Failures Robot]

34 failures in 765 pushes (0.044 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 34

Platform and build breakdown:

• windows11-64-2009-qr: 8
  • opt: 4
  • debug: 4
• linux1804-64-qr: 4
  • debug: 2
  • opt: 2
• windows11-32-2009-qr: 4
  • opt: 2
  • debug: 2
• macosx1015-64-qr: 4
  • opt: 2
  • debug: 2
• linux1804-64-shippable-qr: 2
  • opt: 2
• windows11-64-2009-shippable-qr: 4
  • opt: 4
• windows11-32-2009-shippable-qr: 2
  • opt: 2
• linux1804-64-ccov-qr: 2
  • opt: 2
• macosx1015-64-shippable-qr: 2
  • opt: 2
• windows11-64-2009-ccov-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1870014&startday=2023-12-14&endday=2023-12-14&tree=all

Comment 7

[Intermittent Failures Robot]

34 failures in 4224 pushes (0.008 failures/push) were associated with this bug in the last 7 days.

This is the #30 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• comm-central: 34

Platform and build breakdown:

• windows11-64-2009-qr: 8
  • opt: 4
  • debug: 4
• linux1804-64-qr: 4
  • debug: 2
  • opt: 2
• windows11-32-2009-qr: 4
  • opt: 2
  • debug: 2
• macosx1015-64-qr: 4
  • opt: 2
  • debug: 2
• linux1804-64-shippable-qr: 2
  • opt: 2
• windows11-64-2009-shippable-qr: 4
  • opt: 4
• windows11-32-2009-shippable-qr: 2
  • opt: 2
• linux1804-64-ccov-qr: 2
  • opt: 2
• macosx1015-64-shippable-qr: 2
  • opt: 2
• windows11-64-2009-ccov-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1870014&startday=2023-12-11&endday=2023-12-17&tree=all