1870724 - newsgroup not prompting for password

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[david]

Steps to reproduce:

Set up usenet account. Clicked in server settings to always prompt for authentication. Clicked subscribe and no prompt for password. I repeated this on the standard release, 115, and was successful.

Actual results:

Since there was no prompt, the news server did not download the list of groups. I was using news.eternal-september.org

Expected results:

If properly prompted for password, the server would have listed all groups to which I could subscribe.

Comment 1

[david]

This problem happened in the DAILY release. If not relevant, please close the bug report.

Comment 2

[Bogomil Shopov[:Bogomil]]

I can reproduce it. This is the error I got:

TypeError: can't access property "formatValueSync", this.l10n is undefinedMsgAsyncPrompter.jsm:288:9
    promptUsernameAndPassword resource:///modules/MsgAsyncPrompter.jsm:288
    _actionAuthUser resource:///modules/NntpClient.jsm:839
    _nextAction resource:///modules/NntpClient.jsm:550
    _onData resource:///modules/NntpClient.jsm:219
    Subscribe chrome://messenger/content/mailCommands.js:456
    MsgSubscribe chrome://messenger/content/mailWindowOverlay.js:1130
    onCommand chrome://messenger/content/about3Pane.js:630
    handleEvent chrome://messenger/content/about3Pane.js:292

and

mailnews.nntp: Failed to process server response [object Object]. NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: 
[JavaScript Error: "can't access property "formatValueSync", this.l10n is undefined" {file: "resource:///modules/MsgAsyncPrompter.jsm" line: 288}]'[JavaScript Error: "can't access property "formatValueSync", this.l10n is undefined" {file: "resource:///modules/MsgAsyncPrompter.jsm" line: 288}]' when calling method: [nsIAuthPrompt::promptUsernameAndPassword]
    _actionAuthUser resource:///modules/NntpClient.jsm:839
    _nextAction resource:///modules/NntpClient.jsm:550
    _onData resource:///modules/NntpClient.jsm:219
    Subscribe chrome://messenger/content/mailCommands.js:456
    MsgSubscribe chrome://messenger/content/mailWindowOverlay.js:1130
    onCommand chrome://messenger/content/about3Pane.js:630
    handleEvent chrome://messenger/content/about3Pane.js:292

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: Bug 1870724 - Properly access MsgAuthPrompt.l10n. r=freaktechnik

Fix mistake in bug 1870014 - need to access l10n stacically.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ca34b49aa8cb
Properly access MsgAuthPrompt.l10n. r=freaktechnik

Comment 5

[david]

I just downloaded 123.0a1 today (12/21) and it WORKS! Thanks much for fixing this .:)

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9369640 [details]
Bug 1870724 - Properly access MsgAuthPrompt.l10n. r=freaktechnik

[Approval Request Comment]
Regression caused by (bug #): bug 1870014
User impact if declined: don't get mail/news auth prompts as one should (so may be unable to log in)
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): very safe

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9369640 [details]
Bug 1870724 - Properly access MsgAuthPrompt.l10n. r=freaktechnik

[Triage Comment]
Approved for beta

Comment 8

[Daniel Darnell [:dandarnell]]

Thunderbird 122.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/3aa06a2a9a23