1870367 - Distinguish the translation source under translation_request for telemetry

Status: RESOLVED FIXED

(Firefox :: Translations, enhancement, P3)

Description

[Erik Nordin [:nordzilla]]

Description

This bug tracks the progress of allowing Translations telemetry to distinguish whether a translation request came from full-page translations or from select translations.

---

Steps to implement

• Add a field to the translation_request telemetry item for the translation source.

---

Tests to implement

• Test that full-page translations are marked as full page.
• Test that select translations are marked as select.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 1870367 - Rename langPairPromise return values r=#translations-reviewers!

Comment 2

[Erik Nordin [:nordzilla]]

Attachment: Bug 1870367 - Rework Translations Telemetry Logging r=#translations-reviewers!

Reworks the Translations Telemetry logging to conform
to the pref "toolkit.telemetry.translations.logLevel"
and updates the logging format to be more consistent
and easy to follow in the JS console.

Depends on D208583

Comment 3

[Erik Nordin [:nordzilla]]

Attachment: Bug 1870367 - Rename FullPageTranslations telemetry r=#translations-reviewers!

Renames all telemetry functions related to the FullPageTranslationsPanel
to be clear about their relationship to full-page translations
as opposed to select translations or shared functionality.

Depends on D210956

Comment 4

[Erik Nordin [:nordzilla]]

Attachment: Bug 1870367 - Instrument SelectTranslationsPanel with telemetry r=#translations-reviewers!

Adds all relevant telemetry to the SelectTranslationsPanel

Depends on D210957

Comment 5

[Erik Nordin [:nordzilla]]

Attachment: Bug 1870367 - Add SelectTranslationsPanel Telemetry Tests r=#translations-reviewers!

Adds comprehensive testing of the SelectTranslationsPanel
telemetry events, and updates the FullPageTranslationsPanel
telemetry tests to assert for the correct translation category.

Depends on D210958

Comment 6

[Phabricator Automation]

Comment on attachment 9398549 [details]
Bug 1870367 - Rename langPairPromise return values r=#translations-reviewers!

Revision D208583 was moved to bug 1870368. Setting attachment 9398549 [details] to obsolete.

Comment 7

[Phabricator Automation]

Comment on attachment 9402833 [details]
Bug 1870367 - Rework Translations Telemetry Logging r=#translations-reviewers!

Revision D210956 was moved to bug 1870368. Setting attachment 9402833 [details] to obsolete.

Comment 8

[Phabricator Automation]

Comment on attachment 9402834 [details]
Bug 1870367 - Rename FullPageTranslations telemetry r=#translations-reviewers!

Revision D210957 was moved to bug 1870368. Setting attachment 9402834 [details] to obsolete.

Comment 9

[Phabricator Automation]

Comment on attachment 9402835 [details]
Bug 1870367 - Instrument SelectTranslationsPanel with telemetry r=#translations-reviewers!

Revision D210958 was moved to bug 1870368. Setting attachment 9402835 [details] to obsolete.

Comment 10

[Phabricator Automation]

Comment on attachment 9402836 [details]
Bug 1870367 - Add SelectTranslationsPanel Telemetry Tests r=#translations-reviewers!

Revision D210959 was moved to bug 1870368. Setting attachment 9402836 [details] to obsolete.

Comment 11

[Erik Nordin [:nordzilla]]

Fixed by Bug 1870368