1870368 - Instrument Select Translations Panel UI with flow-id telemetry

Status: RESOLVED FIXED

(Firefox :: Translations, enhancement, P3)

Description

[Erik Nordin [:nordzilla]]

Description

This bug tracks the progress of instrumenting the UI components of the Select Translations Panel to be able to track the user flow of interaction within the panel.

---

Steps to implement

• Add telemetry events for each UI component interaction
• Trigger telemetry events when relevant UI components are invoked

---

Tests to implement

• Test the flow of the Translations panel UI and ensure that telemetry events are counted with the correct data and cardinality.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 1870368 - Rename langPairPromise return values r=#translations-reviewers!

Renames the returned values from langPairPromise to be
{ fromLanguage, toLanguage } rather than { fromLang, toLang }
to be more consistent with the rest of the code.

Depends on D210826

Comment 2

[Erik Nordin [:nordzilla]]

Attachment: Bug 1870368 - Rework Translations Telemetry Logging r=#translations-reviewers!

Reworks the Translations Telemetry logging to conform
to the pref "toolkit.telemetry.translations.logLevel"
and updates the logging format to be more consistent
and easy to follow in the JS console.

Depends on D208583

Comment 3

[Erik Nordin [:nordzilla]]

Attachment: Bug 1870368 - Rename FullPageTranslations telemetry r=#translations-reviewers!

Renames all telemetry functions related to the FullPageTranslationsPanel
to be clear about their relationship to full-page translations
as opposed to select translations or shared functionality.

Depends on D210956

Comment 4

[Erik Nordin [:nordzilla]]

Attachment: Bug 1870368 - Add new SelectTranslationsPanel telemetry events r=#translations-reviewers!

Adds all relevant telemetry to the SelectTranslationsPanel

Depends on D210957

Comment 5

[Erik Nordin [:nordzilla]]

Attachment: Bug 1870368 - Add SelectTranslationsPanel Telemetry Tests r=#translations-reviewers!

Adds comprehensive testing of the SelectTranslationsPanel
telemetry events, and updates the FullPageTranslationsPanel
telemetry tests to assert for the correct translation category.

Depends on D210958

Comment 6

[Erik Nordin [:nordzilla]]

Attachment: Bug 1870368 - Rework TranslationsTelemetry event assertions r=#translations-reviewers!

Reworks the telemetry event assertions in the Translations
test suite to show the contents of which values did not match
the expectations in the error message logs, instead of just reporting
true or false that the value did not match.

Depends on D210959

Comment 7

[Erik Nordin [:nordzilla]]

Attachment: Bug 1870368 - Instrument SelectTranslationsPanel with telemetry r=#translations-reviewers!

Adds all relevant telemetry to the SelectTranslationsPanel

Depends on D210958

Depends on D210958

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe36ddf751aa
Rename langPairPromise return values r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/ae82c8201e72
Rework Translations Telemetry Logging r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/17f9d17ac45f
Rename FullPageTranslations telemetry r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/bd0877c4a195
Add new SelectTranslationsPanel telemetry events r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/ef9de9cc57a5
Instrument SelectTranslationsPanel with telemetry r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/9bc63b18ff85
Add SelectTranslationsPanel Telemetry Tests r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/a74717a231d3
Rework TranslationsTelemetry event assertions r=translations-reviewers,gregtatum

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/fe36ddf751aa
https://hg.mozilla.org/mozilla-central/rev/ae82c8201e72
https://hg.mozilla.org/mozilla-central/rev/17f9d17ac45f
https://hg.mozilla.org/mozilla-central/rev/bd0877c4a195
https://hg.mozilla.org/mozilla-central/rev/ef9de9cc57a5
https://hg.mozilla.org/mozilla-central/rev/9bc63b18ff85
https://hg.mozilla.org/mozilla-central/rev/a74717a231d3