1870817 - TB 115 starts with blank window - searchFolders folder.dbFolderInfo 0x80550005

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[betterbird.project+13]

Attachment: error-console.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36 Edg/120.0.0.0

Steps to reproduce:

Error log attached. We will provide a patch.

Comment 1

[betterbird.project+13]

https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1870817-blank-pane-virtual-folder.patch

Comment 2

[Magnus Melin [:mkmelin]]

Having everything in try-catch isn't ideal. I think I see what we could do to avoid this.

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: Bug 1870817 - On db issues initializing smart folders, generate them to avoid blank 3pane. r=#thunderbird-reviewers

Comment 4

[betterbird.project+13]

We considered that approach. Now it will fail on for (let searchFolder of wrappedFolder.searchFolders) { since wrappedFolder is returned null.

Comment 5

[betterbird.project+13]

Correction of the second sentence in the previous comment: With D196959 it will throw here:
https://searchfox.org/comm-central/rev/a809210935b35cbc62799d2a17ee1a1fcc3a93f2/mailnews/base/src/VirtualFolderWrapper.jsm#126

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/244fa69e97ce
On db issues initializing smart folders, generate them to avoid blank 3pane. r=freaktechnik

Comment 9

[Wayne Mery (:wsmwk)]

Good for beta?

Comment 10

[Magnus Melin [:mkmelin]]

Comment on attachment 9369642 [details]
Bug 1870817 - On db issues initializing smart folders, generate them to avoid blank 3pane. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): supernova, if any bug in particular
User impact if declined: may end up with blank 3pane
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): shouldn't be risky

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9369642 [details]
Bug 1870817 - On db issues initializing smart folders, generate them to avoid blank 3pane. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 122.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/1ea7ffcd92c1

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9369642 [details]
Bug 1870817 - On db issues initializing smart folders, generate them to avoid blank 3pane. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Comment 14

[Daniel Darnell [:dandarnell]]

Thunderbird 115.7.0:
https://hg.mozilla.org/releases/comm-esr115/rev/a262528d8e5e