1872285 - Add a check for a button or link within a listitem in a focusable Firefox View list in the a11y-checks

Status: RESOLVED FIXED

(Firefox :: Firefox View, task, P3)

Description

[Anna Yeddi [:ayeddi]]

In the Firefox View main view, within the <fxview-tab-list> list component, there are a.fxview-tab-row-main and button.fxview-tab-row-secondary-button elements which focusability is handled by the JavaScript - they are made not focusable by default to reduce the number of tabstops needed for a keyboard user to navigate through the Firefox View and each list has only one control that is made keyboard focusable.

The main view of Firefox View has role="application" set which communicates to a screen reader user that a custom navigation pattern is to be expected. But since hyperlinks and buttons are expected to be made individually focusable, Tier 2 a11y_checks are currently failing the ifKeyboardFocusable check for these controls.

We need to add an custom exemption check for the Firefox View tab-row controls in the AccessibilityUtils to automatically pass these elements while the current navigation pattern is used.

Comment 1

[Anna Yeddi [:ayeddi]]

Attachment: Bug 1872285 - Add a check for a button or link within a listitem in a focusable Firefox View list in the AccessibilityUtils. r=Jamie!

In the Firefox View main view, within the <fxview-tab-list> list component, there are a.fxview-tab-row-main and button.fxview-tab-row-secondary-button elements which focusability is handled by the JavaScript - they are made not focusable by default to reduce the number of tabstops needed for a keyboard user to navigate through the Firefox View and each list has only one control that is made keyboard focusable.

The main view of Firefox View has role="application" set which communicates to a screen reader user that a custom navigation pattern is to be expected. But since hyperlinks and buttons are expected to be made individually focusable, Tier 2 a11y_checks are currently failing the ifKeyboardFocusable check for these controls.

We need to add an custom exemption check for the Firefox View tab-row controls in the AccessibilityUtils to automatically pass these elements while the current navigation pattern is used.

Since some Firefox View tests will start passing a11y_checks, we also update the appropriate test manifests correcting the fail-if notations.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9335c5177f4
Add a check for a button or link within a listitem in a focusable Firefox View list in the AccessibilityUtils. r=Jamie,fxview-reviewers

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b9335c5177f4