Closed Bug 1867378 Opened 1 year ago Closed 1 year ago

Investigate how a FXVIEW-CATEGORY-BUTTON in the Firefox View tests needs to be updated to pass a11y_checks

Categories

(Firefox :: Firefox View, defect, P3)

defect

Tracking

()

RESOLVED FIXED
123 Branch
Accessibility Severity s4
Tracking Status
firefox123 --- fixed

People

(Reporter: ayeddi, Assigned: ayeddi)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(4 files)

In the Firefox View side navigation component, the <fxview-category-button> elements with role="tab" include <button aria-hidden="true" tabindex="-1"> which are ultimately receiving clicks from the mochitests. This hacky markup is providing as-expected behavior for the end users who are interacting with tabs within a tablist - as expected.

But on the markup side, this implementation uses those inaccessible (via aria-hidden) buttons, which causes the a11y-checks failures and would likely cause automatic HTML tests to flag this approach too, because it is not an expected pattern and, in general, we do not want this to be reused in any other component.

Since it is working, we would likely not need to re-markup the entire component in this specific case, but we would need to add comments in the test files, describing that this is a one-off instance and to setEnv to tell Tier 2 a11y-checks that as well.

// TODO: Rewrite the description. Testable example: browser/components/firefoxview/tests/browser/firefoxview-next/browser_firefoxview_next_navigation.js

In the Firefox View side navigation component, the <fxview-category-button> elements with role="tab" include <button aria-hidden="true" tabindex="-1"> which are ultimately receiving clicks from the mochitests. This hacky markup is providing as-expected behavior for the end users who are interacting with tabs within a tablist - as expected.

But on the markup side, this implementation uses those inaccessible (via aria-hidden) buttons, which causes the a11y-checks failures and would likely cause automatic HTML tests to flag this approach too, because it is not an expected pattern and, in general, we do not want this to be reused in any other component.

Since it is working, we would likely not need to re-markup the entire component in this specific case, but then we need to add comments in the test files, describing that this is a one-off instance and to setEnv to tell Tier 2 a11y-checks that as well.

With this patch the a11y-checks won't be failing for the affected test files, we are removing the fail-if annotations from the test manifest that were added by the bug 1854625 before the investigation under the meta bug 1854626 happened.

Depends on D194944

Assignee: nobody → ayeddi
Status: NEW → ASSIGNED
Attachment #9366439 - Attachment description: WIP: Bug 1867378 - Add a check for a tab in a focusable tablist in the a11y-checks - based on the Firefox View. r=Jamie → WIP: Bug 1867378 - Add a check for a tab in a focusable tablist in the a11y-checks - based on the Firefox View. r=Jamie
Attachment #9367407 - Attachment description: WIP: Bug 1867378 - Update the test manifest for FXVIEW-CATEGORY-BUTTON cases that are passing a11y-checks → Bug 1867378 - Update the test manifest for FXVIEW-CATEGORY-BUTTON cases that are passing a11y-checks
Attachment #9366439 - Attachment description: WIP: Bug 1867378 - Add a check for a tab in a focusable tablist in the a11y-checks - based on the Firefox View. r=Jamie → Bug 1867378 - Add a check for a tab in a focusable tablist in the a11y-checks - based on the Firefox View. r=Jamie
Attachment #9367407 - Attachment description: Bug 1867378 - Update the test manifest for FXVIEW-CATEGORY-BUTTON cases that are passing a11y-checks → Bug 1867378 - Update the test manifest for FXVIEW-CATEGORY-BUTTON cases that are passing a11y-checks. r=sclements

When the D195198 would be ready to land, there are a few tests that are going to be passing all a11y-checks since the AccessibilityUtils would be able to automatically check focusable tabs in tablists (that were previously failing these tests) or some of them, thus we need to update the manifest to remove fail-if notations when appropriate and update the comments in the remaining tests

Depends on D195745

When the D195198 would be ready to land, there are a few tests that are going to be passing all or most of a11y-checks since the AccessibilityUtils would be able to automatically check focusable tabs in tablists (that were previously failing these tests), thus we need to update the manifest to remove fail-if notations when appropriate and update the comments in the remaining tests.

Depends on D197025

Attachment #9369761 - Attachment description: Bug 1867378 - Pt.3. Update the test manifest for Add-ons Manager tabpanel cases that are passing a11y-checks. r=Jamie → Bug 1867378 - Pt.3. Update the test manifest for Add-ons Manager tabpanel cases that are passing a11y-checks.
Attachment #9367407 - Attachment description: Bug 1867378 - Update the test manifest for FXVIEW-CATEGORY-BUTTON cases that are passing a11y-checks. r=sclements → Bug 1867378 - Pt.2. Update the test manifest for FXVIEW-CATEGORY-BUTTON cases that are passing a11y-checks. r=sclements
Attachment #9366439 - Attachment description: Bug 1867378 - Add a check for a tab in a focusable tablist in the a11y-checks - based on the Firefox View. r=Jamie → Bug 1867378 - Pt.1. Add a check for a tab in a focusable tablist in the a11y-checks - based on the Firefox View. r=Jamie
See Also: → 1872285
Pushed by ayeddi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/54b256edce57 Pt.1. Add a check for a tab in a focusable tablist in the a11y-checks - based on the Firefox View. r=Jamie,fxview-reviewers https://hg.mozilla.org/integration/autoland/rev/8c4ae92db831 Pt.2. Update the test manifest for FXVIEW-CATEGORY-BUTTON cases that are passing a11y-checks. r=fxview-reviewers,sclements https://hg.mozilla.org/integration/autoland/rev/88e5fb826292 Pt.3. Update the test manifest for Add-ons Manager tabpanel cases that are passing a11y-checks. r=extension-reviewers,zombie https://hg.mozilla.org/integration/autoland/rev/e247bde2e205 [devtools] Pt.4. Update the test manifest for DevTools tabpanel cases that are passing a11y-checks. r=devtools-reviewers,ochameau
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: