1854625 - Temporarily disable some Tier 2 a11y_checks for Firefox View

Status: RESOLVED FIXED

(Firefox :: Firefox View, task, P3)

Description

[Anna Yeddi [:ayeddi]]

We are working on enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to skip the failing tests altogether and then handle each one of them individually.

This task is to skip with fail-if condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved. A separate task to investigate the failed Tier 2 a11y_checks will be filed for an appropriate component.

Tests affected:

Result	Path	Error	Element ID	Element tagName	Element className
FAIL	browser/components/firefoxview/tests/browser/browser_feature_callout.js	Node is not accessible via accessibility API		IMG	brand-logo
FAIL	browser/components/firefoxview/tests/browser/browser_feature_callout.js	Node is not accessible via accessibility API		DIV	brand-logo
FAIL	browser/components/firefoxview/tests/browser/browser_recently_closed_tabs_windows.js	Node is not focusable via the accessibility API		A	closed-tab-li-title
FAIL	browser/components/firefoxview/tests/browser/browser_recently_closed_tabs.js	Node is not focusable via the accessibility API		A	closed-tab-li-title
FAIL	browser/components/firefoxview/tests/browser/firefoxview-next/browser_history_firefoxview_next.js	Node is not accessible via accessibility API		BUTTON	
FAIL	browser/components/firefoxview/tests/browser/firefoxview-next/browser_recentlyclosed_firefoxview_next.js	Node is not focusable via the accessibility API	fxview-tab-row-main	A	 fxview-tab-row-main 
FAIL	browser/components/firefoxview/tests/browser/firefoxview-next/browser_recentlyclosed_firefoxview_next.js	Node is not accessible via accessibility API		BUTTON	
FAIL	browser/components/firefoxview/tests/browser/firefoxview-next/browser_recentlyclosed_firefoxview_next.js	Node is not focusable via the accessibility API	fxview-tab-row-secondary-button	BUTTON	fxview-tab-row-button ghost-button icon-button semi-transparent
FAIL	browser/components/firefoxview/tests/browser/firefoxview-next/browser_recentlyclosed_firefoxview_next.js	Node is not accessible via accessibility API		BUTTON	
FAIL	browser/components/firefoxview/tests/browser/firefoxview-next/browser_recentlyclosed_firefoxview_next.js	Node is not accessible via accessibility API		BUTTON	
FAIL	browser/components/firefoxview/tests/browser/firefoxview-next/browser_syncedtabs_errors_firefoxview_next.js	Node is not accessible via accessibility API		BUTTON	
FAIL	browser/components/firefoxview/tests/browser/firefoxview-next/browser_syncedtabs_errors_firefoxview_next.js	Node is not accessible via accessibility API		BUTTON	
FAIL	browser/components/firefoxview/tests/browser/firefoxview-next/browser_syncedtabs_firefoxview_next.js	Node is not accessible via accessibility API		BUTTON	
FAIL	browser/components/firefoxview/tests/browser/firefoxview-next/browser_syncedtabs_firefoxview_next.js	Node is not accessible via accessibility API		BUTTON	
FAIL	browser/components/firefoxview/tests/browser/firefoxview-next/browser_syncedtabs_firefoxview_next.js	Node is not accessible via accessibility API		BUTTON	
FAIL	browser/components/firefoxview/tests/browser/firefoxview-next/browser_syncedtabs_firefoxview_next.js	Node is not accessible via accessibility API		BUTTON	

Jobs affected:

1. test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-a11y-checks-${1-7} (Try run)

---

Some Tier 2 accessibility checks for click events fired on controls that should be keyboard accessible and have valid labels were failing for this component. They were captured by testing/mochitest/tests/SimpleTest/AccessibilityUtils.js via bug 1692110. These failing tests should be temporarily skipped in the directory's browser.ini file while we investigate these failures. For all confirmed bugs individual defects should be filed.

When the individual test failures are resolved and the individual bugs are closed, remove the fail-if condition for a11y_checks from the appropriate files/sections to ensure better test coverage and to avoid regressions in a11y of these components.

Comment 1

[Anna Yeddi [:ayeddi]]

Attachment: Bug 1854625 - Temporarily fail-if some Tier 2 a11y_checks for Firefox View. r=kcochrane!,#fxview-reviewers,Jamie

We are working on enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to skip the failing tests altogether and then handle each one of them individually.

This task is to skip with fail-if condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved.

Related bugs:

• Disabling tests: meta bug 1848402
• Investigation and remediation for components with disabled tests: meta bugs 1848394 and 1854227, Firefox View-specific meta bug 1854626
• Explore capturing click events for a11y_checks: bug 1692110

Depends on D188927

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7529a962a8c
Temporarily disable some Tier 2 a11y_checks for Firefox View. r=fxview-reviewers,kcochrane

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c7529a962a8c

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out for causing multiple tier 2 failures on
Backout link
Push with failures

https://bugzilla.mozilla.org/show_bug.cgi?id=1857672
https://bugzilla.mozilla.org/show_bug.cgi?id=1857666
https://bugzilla.mozilla.org/show_bug.cgi?id=1857664
https://bugzilla.mozilla.org/show_bug.cgi?id=1857665
https://bugzilla.mozilla.org/show_bug.cgi?id=1857707

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68e745769848
Temporarily fail-if some Tier 2 a11y_checks for Firefox View. r=fxview-reviewers,kcochrane

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/68e745769848